Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Deletion Bug #355

Closed
Mkellyeng opened this issue May 22, 2019 · 5 comments
Closed

Window Deletion Bug #355

Mkellyeng opened this issue May 22, 2019 · 5 comments

Comments

@Mkellyeng
Copy link
Contributor

If you delete a space that has a window, by using the delete button, you cannot draw any new spaces on that floor.

It appears using the delete button to delete a space doesn't remove windows that are associated with that space, leaving them with a dangling reference.

This results in very strange behaviour that prevents you from drawing any new spaces on that floor. The drawing tools behave as though you're using 'Polygon' (regardless of whether you have rectangle or polygon selected), but you can't accept the shape, finalising the space.

This behaviour is only seen on the floor where the bug was triggered, other floors still behaviour as normal. Saving the file and re-opening retains the bug, but saving, manually removing the window, and re-opening, removes the bug.

See the attached zip file for examples of both the bugged and fixed state

Window Deletion Bug.zip
Window Deletion Bug

@bgschiller
Copy link
Collaborator

Hi @Mkellyeng, A couple other people have noticed this same problem! I think we have a patch for it over in #356 , but some of the (unrelated) tests are failing. I'm hoping to find time soon to fix up those tests so I can merge the branch in.

@bgschiller
Copy link
Collaborator

Closing, as I believe this is fixed now that #356 is merged.

@Mkellyeng
Copy link
Contributor Author

@bgschiller was this fix only for the open studio version? I can still replicate in the online version
image

@kylem038
Copy link
Collaborator

kylem038 commented Jul 2, 2021

@Mkellyeng I've tested this out on the webapp and it appears to have been resolved. Let us know if you're still able to recreate it.

@Mkellyeng
Copy link
Contributor Author

Re-tested, Issue is resolved! Fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants