Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Origin Resource Sharing (CORS) support? #81

Closed
brylie opened this issue Jan 5, 2015 · 5 comments
Closed

Cross-Origin Resource Sharing (CORS) support? #81

brylie opened this issue Jan 5, 2015 · 5 comments
Labels
Milestone

Comments

@brylie
Copy link
Contributor

brylie commented Jan 5, 2015

As an API manager,
I would like to quickly add CORS support to any defined API
So that developers can make cross-origin requests easily

Proposal (1)- documentation

Add 'cookbook' style CORS recipe to API Umbrella docs, describing what header values to add/modify to enable CORS support on proxy endpoints.

Proposal (2) - toggle widget

Create 'Enable CORS' toggle switch on endpoint configuration screen, with corresponding informative text of the implications of enabling CORS.

Proposal (3) - Auto-configure button

Add a button to the header configuration section of the UI to "Add CORS headers". The header fields will be created and user-editable.

@GUI
Copy link
Member

GUI commented Jan 6, 2015

I'm somewhat inclined to favor Proposal 3, where API Umbrella could automatically add the CORS headers on any responses proxied through it.

While we've generally avoided modifying the API responses at the API Umbrella layer, I think CORS is such a simple thing that a lot of people want to always be defaulting to, that it could certainly make sense to have an option to force the CORS headers at the API Umbrella layer. A few other people have also requested this, so it's something I'd like to do, and it should be pretty straight forward to implement.

And just for my own tracking purposes and to tie these issues together, here's a counterpart issue to this for our api.data.gov project: 18F/api.data.gov#120

@kyyberi
Copy link

kyyberi commented Jan 6, 2015

+1

@brylie
Copy link
Contributor Author

brylie commented Jan 7, 2015

@kyyberi sent me a link to his CORS implementation.

@GUI
Copy link
Member

GUI commented Jul 29, 2015

Belatedly closing this, since this was part of the v0.8 release.

@as33ms
Copy link

as33ms commented Aug 14, 2015

@GUI : If I understand correct, then the required changeset (for modifying response headers) is not a part of the current available debian (at apiumbrella.io/download | api-umbrella_0.8.0-1_amd64.deb). Do you have any idea when the latest version (v0.8.16) is going to be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants