Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Admin UI to Ember 2 #257

Closed
GUI opened this issue Jul 10, 2016 · 1 comment
Closed

Upgrade Admin UI to Ember 2 #257

GUI opened this issue Jul 10, 2016 · 1 comment
Assignees
Milestone

Comments

@GUI
Copy link
Member

GUI commented Jul 10, 2016

The admin app is currently an Ember 1.7 application living inside the Rails web-app component. It would be good to upgrade this to a more recent version of Ember that has better support these days.

As part of this upgrade, it would also be a good idea to pull the admin app outside of the Rails web-app component and into a standalone Ember CLI app. Now that the admin interface has really turned into an Ember-only app (utilizing the various admin APIs), and now that Ember CLI is the standard way to develop Ember apps, it would be a better fit for future development.

It would also be good to upgrade Ember from a security perspective. For example, the current version of Handlebars.js our Ember app is locked to has a security advisory. While I've audited our code-base to ensure we're not vulnerable to that specific issue, upgrading would be a better long-term fix.

This upgrade is currently in progress on the admin-upgrade branch. In there, the root of the Ember CLI app is at src/api-umbrella/admin-ui.

@GUI
Copy link
Member Author

GUI commented Dec 8, 2016

Landed in #312

@GUI GUI closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant