-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Molten Salt Linear Fresnel Model and IPH #1444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tanks and hx logic
Remove 'no financial' options in UI.
…s flow rate. Fix Aux calculation in system control'
…a_price_input variable type. Modify merchant default file. Remove unnecessary dispatch optimization UI field. Set correct opt_type in default files
… Synchronize defaults with old molten salt linear fresnel model and trough model for dispatch
…ispatch factors to single array
…SS receiver and header heat loss to UI. Add piping summary to notices
cpaulgilman
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. A couple of comments:
- Should we use "Industrial Process Heat" instead of "Heat" in the configuration chooser? "Heat" is a little ambiguous.
- I get a callback error when I try to open a file with a default MSLF / Single Owner case created by SAM 2022.11.21 r3. This may be something we could resolve after merging into Develop.
cpaulgilman
added
the
requires help revision
Requires a Help revision before releasing public version
label
Sep 15, 2023
tyneises
approved these changes
Sep 15, 2023
Use configopt() approach from Hybrids branch to create `tree_parent` in startup.lk. Rename "Heat" category to "Industrial Process Heat".
cpaulgilman
added
the
added to release notes
PR and/or issue has been added to release notes for a public release
label
Dec 1, 2023
cpaulgilman
removed
the
requires help revision
Requires a Help revision before releasing public version
label
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
added to release notes
PR and/or issue has been added to release notes for a public release
csp
concentrating solar power
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overhauled the molten salt linear fresnel model. Now uses the same CSP controller and solver as the power tower and parabolic trough models. Added mslf IPH model. Removed old molten salt linear fresnel model.
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.