Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Molten Salt Linear Fresnel Model and IPH #1444

Merged
merged 73 commits into from
Sep 18, 2023
Merged

Conversation

taylorbrown75
Copy link
Collaborator

Description

Overhauled the molten salt linear fresnel model. Now uses the same CSP controller and solver as the power tower and parabolic trough models. Added mslf IPH model. Removed old molten salt linear fresnel model.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

taylorbrown75 and others added 30 commits February 23, 2023 14:51
…s flow rate. Fix Aux calculation in system control'
…a_price_input variable type. Modify merchant default file. Remove unnecessary dispatch optimization UI field. Set correct opt_type in default files
… Synchronize defaults with old molten salt linear fresnel model and trough model for dispatch
…SS receiver and header heat loss to UI. Add piping summary to notices
@taylorbrown75 taylorbrown75 added the csp concentrating solar power label Sep 11, 2023
@taylorbrown75 taylorbrown75 added this to the SAM Fall 2023 Release milestone Sep 11, 2023
@taylorbrown75 taylorbrown75 self-assigned this Sep 11, 2023
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A couple of comments:

  • Should we use "Industrial Process Heat" instead of "Heat" in the configuration chooser? "Heat" is a little ambiguous.
  • I get a callback error when I try to open a file with a default MSLF / Single Owner case created by SAM 2022.11.21 r3. This may be something we could resolve after merging into Develop.

@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Sep 15, 2023
Use configopt() approach from Hybrids branch to create `tree_parent` in startup.lk.

Rename "Heat" category to "Industrial Process Heat".
@cpaulgilman cpaulgilman merged commit b4550e2 into develop Sep 18, 2023
4 checks passed
@cpaulgilman cpaulgilman deleted the fresnel-slvr branch October 3, 2023 16:48
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 1, 2023
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release csp concentrating solar power
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants