Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to E+ v24.2.0a #5267

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Update to E+ v24.2.0a #5267

merged 6 commits into from
Oct 7, 2024

Conversation

joseph-robertson
Copy link
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Oct 3, 2024
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 3, 2024

CI Results for 4b2c04d:

@jmarrec jmarrec changed the title Update to E+ v24.2.1-RC1 Update to E+ v24.2.0a Oct 7, 2024
@jmarrec jmarrec marked this pull request as ready for review October 7, 2024 09:38
Built the arm64 linux (22.04 and 24.04), the windows i386, and the Centos one.
https://github.com/NREL/EnergyPlus/releases/tag/v24.2.0a
@jmarrec jmarrec merged commit 25fec1d into v24.2.0-IOFreeze Oct 7, 2024
0 of 4 checks passed
@jmarrec jmarrec deleted the v24.2.1-RC1 branch October 7, 2024 09:49
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 7, 2024

Built the arm64 linux (22.04 and 24.04), the windows i386, and the Centos one.
https://github.com/NREL/EnergyPlus/releases/tag/v24.2.0a

I updated all hashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants