Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5133 - Conversion to/from pathlib.Path in python bindings now rejects openstudio.Path #5170

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Fix #5133 - Conversion to/from pathlib.Path in python bindings now rejects openstudio.Path #5170

merged 3 commits into from
Apr 25, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Apr 25, 2024

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec
#5133 - Add a failing test
1f0d8cf
@jmarrec
Remove python2 block pertaining to PyString_
687e0f5
@jmarrec
Fix #5133 - I messed up the typecheck
7bf9793 
Technically speaking, the typecheck is pointless, but whatever...
typecheck is used for overloading
@jmarrec jmarrec added severity - Normal Bug Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Python bindings labels Apr 25, 2024
@jmarrec jmarrec requested a review from kbenne April 25, 2024 09:47
@jmarrec jmarrec self-assigned this Apr 25, 2024
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Apr 25, 2024 •
edited
Loading

CI Results for 7bf9793:

@jmarrec jmarrec merged commit ae6cba2 into develop Apr 25, 2024
2 of 6 checks passed
@jmarrec jmarrec deleted the 5133_toPath_python branch April 25, 2024 12:55
@jmarrec jmarrec mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenne kbenne Awaiting requested review from kbenne

Assignees

@jmarrec jmarrec

Labels
component - Python bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. severity - Normal Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conversion to/from pathlib.Path in python bindings now rejects openstudio.Path
2 participants
@jmarrec @ci-commercialbuildings