Fix compiler issues

[macumber]

Pull request overview

Fixes compiler issues I hit when attempting to build with Microsoft Visual Studio Community 2022 (64-bit) - Version 17.9.6

New definitions needed to overcome:

Severity	Code	Description	Project	File	Line	Suppression State	Details
Warning	C4996	'stdext::checked_array_iterator<T *>': warning STL4043: stdext::checked_array_iterator, stdext::unchecked_array_iterator, and related factory functions are non-Standard extensions and will be removed in the future. std::span (since C++20) and gsl::span can be used instead. You can define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING or _SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS to suppress this warning.
        with
        [
            T=fmt::v9::detail::bigint::bigit
        ]	GenerateIddFactory	C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.39.33519\include\xutility	1151		

Public linking of openstudiolib in openstudio_workflow needed to overcome:

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	LNK2005	"public: virtual __cdecl openstudio::IdfObject::~IdfObject(void)" (??1IdfObject@openstudio@@UEAA@XZ) already defined in RunPreProcessMonthlyReports_GTest.obj	openstudio_workflow_tests	C:\repos\os\debug\src\workflow\openstudiolib.lib(openstudiolib.dll)	1	

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

I don't really have an issue with these

[jmarrec]

This one looks slightly problematic to me, especially since it appears the issue is in the workflow_test

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	LNK2005	"public: virtual __cdecl openstudio::IdfObject::~IdfObject(void)" (??1IdfObject@openstudio@@UEAA@XZ) already defined in RunPreProcessMonthlyReports_GTest.obj	openstudio_workflow_tests	C:\repos\os\debug\src\workflow\openstudiolib.lib(openstudiolib.dll)	1	

[macumber]

That is the linker error that this change fixes, I don't know why you would want to PRIVATE link openstudiolib with openstudio_workflow, I don't think you can use openstudio_workflow without also linking openstudiolib

[macumber]

It's possible that this might work instead, I'll try it out:

-target_link_libraries(openstudio_workflow PUBLIC openstudiolib)
+target_link_libraries(openstudio_workflow PRIVATE openstudiolib)

 if(BUILD_TESTING)
   set(openstudio_workflow_test_depends
+    openstudiolib
     openstudio_workflow
-    boost::boost # Maybe at some point replace with openstudiolib more simply
-    fmt::fmt
   )

[macumber]

Yup that works, I can push if you prefer. However, that requires anyone who links openstudio_workflow to also link openstudiolib which is what the PUBLIC link option does.

[jmarrec]

I don't think anyone should link to openstudio_workflow.

[kbenne]

Public is fine to me. You guys understand the implications.

[ci-commercialbuildings]

CI Results for 8e1e8cd:

• Ubuntu 20.04:

  • OpenStudio-3.8.0-rc1+546a419606-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.8.0-rc1+546a419606-Ubuntu-20.04-x86_64.tar.gz

• Ubuntu 22.04:

  • OpenStudio-3.8.0-rc1+f1a6758fa6-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.8.0-rc1+f1a6758fa6-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.8.0-rc1+dd1467b583-Darwin-x86_64.dmg
  • OpenStudio-3.8.0-rc1+dd1467b583-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0-rc1+dfa8997367-Windows.exe
  • OpenStudio-3.8.0-rc1+dfa8997367-Windows.tar.gz

• Code Coverage:

[jmarrec]

@kbenne any opinion here? please