v24.1.0-IOFreeze: No Load Supply Air Flow Rate Control Set To Low Speed

[joseph-robertson]

Pull request overview

New "No Load Supply Air Flow Rate Control Set To Low Speed" field for the following objects:

• ZoneHVAC:PackagedTerminalAirConditioner
• ZoneHVAC:PackagedTerminalHeatPump
• ZoneHVAC:WaterToAirHeatPump
• AirLoopHVAC:UnitarySystem

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[joseph-robertson]

Ummm... should this be "No"? IDF Version Updater sets this to "No" (but the default is "Yes") ...

See resources/energyplus/Office_With_Many_HVAC_Types/in.idf.

[jmarrec]

Looks good to me, but I'd like to see additions to model tests + FT tests for that field (a dozen of lines total)

Also, I'd like to ensure that the "Yes" is the former default. Is it @joseph-robertson ? (either it's documented in E+ that it is, or you've run an Openstudio-resources test that uses these objects and they show no EUI change).

---

Suggestions: changing to getBooleanFieldValue + shortening VT test to avoid annoying maintenance issues.

[joseph-robertson]

On the "No" vs "Yes" default issue...

I tried running fan_on_off.rb on OpenStudio-resources, using both v3.7.0 and v3.8.0-alpha. The energy results change for both "No" and "Yes" (and are the same). So, something else must be accounting for the deviation. And not sure what to make of "No" and "Yes" having identical results.

[jmarrec]

Assuming CI builds fine after I resolved conflicts, we can do ahead and merge this one, it's good enough to go into the main IOFreeze branch, we can figure out the Yes / No EUI deviation later on.

[ci-commercialbuildings]

CI Results for 5c31398:

• Ubuntu 20.04:

• Ubuntu 22.04:

• Darwin:

  • OpenStudio-3.8.0+5c31398f9f-Darwin-x86_64.dmg
  • OpenStudio-3.8.0+5c31398f9f-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0+5c31398f9f-Windows.exe
  • OpenStudio-3.8.0+5c31398f9f-Windows.tar.gz

• Code Coverage: