Improve weather file handling in OS Workflow

[kbenne]

Now we make sure to look in the Model for the final weather file defined after all Measures have run.

We also still iniitialize the weather file from the OSW if one is defined.

close #5009

Pull request overview

• Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[kbenne]

Here is a workflow that demonstrates the issue.

test_workflow_370rc1.zip

[jmarrec]

Workflow gem seem to be doing it in APplyMeasure when it's a ModelMeasure: https://github.com/NREL/OpenStudio-workflow-gem/blob/696306b5b24cd597edc6ab04faa1e618f99db190/lib/openstudio/workflow/util/measure.rb#L551-L571

[jmarrec]

I believe you actually need to complete this unfinished block instead:

OpenStudio/src/workflow/ApplyMeasure.cpp

Lines 215 to 224 in 4d820d0

	if (measureType == MeasureType::ModelMeasure) {
	if (auto weatherFile_ = model.weatherFile()) {
	if (auto p_ = weatherFile_->path()) {
	// Probably a workflowJSON.findFile() call...
	// m_epwPath_ = p_;
	} else {
	LOG(Warn, "Weather file object found in model but no path is given");
	}
	}
	}

[jmarrec]

IIUC this unfinished block is really where it needs to happen, so any downstream OpenStudio ModelMeasure that needs to use the workflow path via runner.lastEpwFile or whatever will get the right info.

[kbenne]

Right. I forgot about Runner::lastEpwFile. But I think it still needs to happen before translation too, because don't we need to account for the fact that the last ModelMeasure could have changed the weather location?

[jmarrec]

Updating last runner epwfile is done prior to measure run currently. The unfinished code block I link to is supposed to be executed after the measure run.
I'm not against changing what workflow-gem does, but it's 1) easier to Match and 2) clearer and probably 3) less error prone