Update gbXML schema to v7.03 #4995

joseph-robertson · 2023-10-11T20:03:33Z

Pull request overview

Addresses #4966.

Checklist:

Update the schema version in XMLValidator::gbxmlValidator()
Update the schema and version in ForwardTranslator::translateModel()
Include new set of test gbXML v7.03 files, and update/add RT tests

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

joseph-robertson · 2023-10-12T16:44:19Z

resources/CMakeLists.txt

+  gbxml/11_Jay_St.xml
+  gbxml/A00.xml
+  gbxml/Building_Central_Conceptual_Model.xml


Add a few files (v7.03) from autodesk's test suite.

joseph-robertson · 2023-10-12T16:44:56Z

src/gbxml/ForwardTranslator.cpp

+    gbXMLElement.append_attribute("xsi:schemaLocation") = "http://www.gbxml.org/schema http://gbxml.org/schema/7-03/GreenBuildingXML_Ver7.03.xsd";
    gbXMLElement.append_attribute("temperatureUnit") = "C";
    gbXMLElement.append_attribute("lengthUnit") = "Meters";
    gbXMLElement.append_attribute("areaUnit") = "SquareMeters";
    gbXMLElement.append_attribute("volumeUnit") = "CubicMeters";
    gbXMLElement.append_attribute("useSIUnitsForResults") = "true";
-    gbXMLElement.append_attribute("version") = "6.01";
+    gbXMLElement.append_attribute("version") = "7.03";


Forward translate with v7.03 header attributes.

Naively would expect some stuff to change in there.
I do realize we only handle geometry (and thermostat), so perhaps it's expected that nothing changes there.

But from a cursory diff of the v6 and v7 schemas, I think we could perhaps handle the new DesignCoolRH and DesignHeatRH by inspecting a potential ZoneControlHumidistat in the ForwardTranslator::translateThermalZone method. Maybe worth an enhancement request, not sure.

joseph-robertson · 2023-10-12T16:46:10Z

src/gbxml/Test/ReverseTranslator_GTest.cpp

@@ -968,3 +968,75 @@ TEST_F(gbXMLFixture, ReverseTranslator_Absorptance) {
    EXPECT_EQ(0.7, _material2->visibleAbsorptance());  // default
  }
 }
+
+TEST_F(gbXMLFixture, ReverseTranslator_v703gbXMLs) {


Add a new test that does gbXML -> model -> gbXML. Then check that the latter gbXML is valid.

I'd prefer breaking these in individual tests, so we get clearer failures in the event they do start failing.

joseph-robertson · 2023-10-12T16:46:41Z

src/utilities/xml/Test/XMLValidator_GTest.cpp

+                                           std::make_tuple("gbxml/TwoStoryOffice_Trane.xml", 0, 236), std::make_tuple("gbxml/ZNETH.xml", 0, 204),
+                                           std::make_tuple("gbxml/11_Jay_St.xml", 0, 0), std::make_tuple("gbxml/A00.xml", 0, 0),
+                                           std::make_tuple("gbxml/Building_Central_Conceptual_Model.xml", 0, 3)),


Test XML validation on the new v7.03 files.

joseph-robertson · 2023-10-12T16:48:10Z

src/utilities/xml/XMLValidator.cpp

+  ::openstudio::embedded_files::extractFile(":/xml/resources/GreenBuildingXML_Ver7.03.xsd", openstudio::toString(tmpDir), quiet);
+  return XMLValidator(tmpDir / "GreenBuildingXML_Ver7.03.xsd");


Validate all gbXML files against the v7.03 schema. This is called prior to RT, and after FT.

I had noted on the first PR that Matt opened that maybe we should add an enum #4980 (comment)

Quoting myself:

Maybe we should use an enum (or a string with validation... ) and modifying the gbxmlValidator signature to take en optional gbxmlVersion parameter?

enum class GbxmlVersion { Ver601, Ver703 }; XMLValidator gbxmlValidator(GbxmlVersion gbxmlVersion = GbxmlVersion::Ver601);

Otherwise perhaps we should delete the GreenBuildingXML_Ver6.01.xsd altogether.

jmarrec · 2023-10-16T09:58:32Z

src/gbxml/ForwardTranslator.cpp

+    gbXMLElement.append_attribute("xsi:schemaLocation") = "http://www.gbxml.org/schema http://gbxml.org/schema/7-03/GreenBuildingXML_Ver7.03.xsd";
    gbXMLElement.append_attribute("temperatureUnit") = "C";
    gbXMLElement.append_attribute("lengthUnit") = "Meters";
    gbXMLElement.append_attribute("areaUnit") = "SquareMeters";
    gbXMLElement.append_attribute("volumeUnit") = "CubicMeters";
    gbXMLElement.append_attribute("useSIUnitsForResults") = "true";
-    gbXMLElement.append_attribute("version") = "6.01";
+    gbXMLElement.append_attribute("version") = "7.03";


Naively would expect some stuff to change in there.
I do realize we only handle geometry (and thermostat), so perhaps it's expected that nothing changes there.

But from a cursory diff of the v6 and v7 schemas, I think we could perhaps handle the new DesignCoolRH and DesignHeatRH by inspecting a potential ZoneControlHumidistat in the ForwardTranslator::translateThermalZone method. Maybe worth an enhancement request, not sure.

jmarrec · 2023-10-16T10:01:47Z

src/utilities/xml/XMLValidator.cpp

+  ::openstudio::embedded_files::extractFile(":/xml/resources/GreenBuildingXML_Ver7.03.xsd", openstudio::toString(tmpDir), quiet);
+  return XMLValidator(tmpDir / "GreenBuildingXML_Ver7.03.xsd");


I had noted on the first PR that Matt opened that maybe we should add an enum #4980 (comment)

Quoting myself:

Maybe we should use an enum (or a string with validation... ) and modifying the gbxmlValidator signature to take en optional gbxmlVersion parameter?

enum class GbxmlVersion { Ver601, Ver703 }; XMLValidator gbxmlValidator(GbxmlVersion gbxmlVersion = GbxmlVersion::Ver601);

Otherwise perhaps we should delete the GreenBuildingXML_Ver6.01.xsd altogether.

jmarrec · 2023-10-16T10:09:46Z

src/gbxml/Test/ReverseTranslator_GTest.cpp

@@ -968,3 +968,75 @@ TEST_F(gbXMLFixture, ReverseTranslator_Absorptance) {
    EXPECT_EQ(0.7, _material2->visibleAbsorptance());  // default
  }
 }
+
+TEST_F(gbXMLFixture, ReverseTranslator_v703gbXMLs) {


I'd prefer breaking these in individual tests, so we get clearer failures in the event they do start failing.

jmarrec · 2023-10-16T10:40:10Z

src/gbxml/Test/ReverseTranslator_GTest.cpp

+  {
+    openstudio::path inputPath = resourcesPath() / openstudio::toPath("gbxml/Building_Central_Conceptual_Model.xml");
+
+    openstudio::gbxml::ReverseTranslator reverseTranslator;
+    openstudio::gbxml::ForwardTranslator forwardTranslator;
+
+    boost::optional<openstudio::model::Model> model = reverseTranslator.loadModel(inputPath);
+    ASSERT_TRUE(model);
+
+    openstudio::path outputPath = resourcesPath() / openstudio::toPath("gbxml/Building_Central_Conceptual_Model_2.xml");
+    bool test = forwardTranslator.modelToGbXML(*model, outputPath);
+    EXPECT_TRUE(test);
+
+    auto xmlValidator = XMLValidator::gbxmlValidator();
+
+    EXPECT_TRUE(xmlValidator.validate(outputPath));
+    EXPECT_TRUE(xmlValidator.isValid());
+    EXPECT_EQ(0, xmlValidator.warnings().size());
+
+    auto errors = xmlValidator.errors();
+    EXPECT_EQ(0, errors.size());
+  }


In debug (emphasis mine)

[ RUN ] gbXMLFixture.ReverseTranslator_v703gbXMLs Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2) Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2) Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2) Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2) Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2) - [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. - openstudio_gbxml_tests: /home/julien/Software/Others/OpenStudio/src/gbxml/Test/../../model/../utilities/core/Assert.hpp:37: void boost::assertion_failed(const char*, const char*, const char*, long int): Assertion `false' failed. - Aborted (core dumped)

In release I get the BOOST_ASSERT issued too, but it doesn't dump.

Click to expand release

[ RUN ] gbXMLFixture.ReverseTranslator_v703gbXMLs_Building_Central_Conceptual_Model [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [BOOST_ASSERT] <2> Assertion std::abs(z) < 0.001 failed on line 890 of boost::optional<pugi::xml_node> openstudio::gbxml::ForwardTranslator::translateSurface(const openstudio::model::Surface&, pugi::xml_node&) in file /home/julien/Software/Others/OpenStudio/src/gbxml/ForwardTranslator.cpp. [ OK ] gbXMLFixture.ReverseTranslator_v703gbXMLs_Building_Central_Conceptual_Model (1127 ms)

Getting a couple LU checks failed on existing files, but no BOOST_ASSERT.

[ RUN ] gbXMLFixture.ForwardTranslator_Issue_4375 Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2) Check failed in file /home/julien/.conan/data/boost/1.79.0/_/_/package/8468b057bf5b2cf5c1e9194777c025a4812bc62f/include/boost/numeric/ublas/lu.hpp at line 298: detail::expression_type_check (prod (triangular_adaptor<const_matrix_type, upper> (m), e), cm2)

Ok, I've checked, the gbXML file does have non-planar surfaces, though I suppose perhaps our tolerance is too small.

from lxml import etree from typing import List def locate_surface(root: etree.Element, surface_name: str): ns = { 'k': root.nsmap[None] } gbxml_sfs = tree.xpath(f"//k:SpaceBoundary[@surfaceIdRef='{surface_name}']", namespaces=ns) if not gbxml_sfs: raise ValueError(f"Surface {surface_name} was not found") n_found = len(gbxml_sfs) if n_found != 1: print(f"Found {n_found} surfaces, expected only one") return gbxml_sfs[0] def parse_surface_coordinates(gbxml_sf: etree.Element) -> List[openstudio.Point3d]: points = [] for pt in gbxml_sf.getchildren()[0].getchildren()[0].getchildren(): x, y, z = pt.getchildren() x = float(x.text) y = float(y.text) z = float(z.text) points.append(openstudio.Point3d(x, y, z)) print(f"Found {len(points)} points") return points xmlPath = Path('../../resources/gbxml/Building_Central_Conceptual_Model.xml') assert xmlPath.is_file() tree = etree.parse(str(xmlPath)) root = tree.getroot() gbxml_sf = locate_surface(root=root, surface_name='aim11994') points = parse_surface_coordinates(gbxml_sf=gbxml_sf) # Compute the plane, check if the points are properly on it plane = openstudio.Plane(points) print(plane) tol = 0.001 # Default tolerance for i, v in enumerate(points): if not plane.pointOnPlane(v, tol): projected = plane.project(v) diff = v - projected dist = diff.length() print(f"Vertex {i} is not on the plane: dist = {dist:.4f}")

output:

Found 20 points [0.173657, 0.984806, 8.06117e-05, -20.271] Vertex 0 is not on the plane: dist = 0.0014 Vertex 1 is not on the plane: dist = 0.0015 Vertex 2 is not on the plane: dist = 0.0016 Vertex 3 is not on the plane: dist = 0.0025 Vertex 4 is not on the plane: dist = 0.0025 Vertex 5 is not on the plane: dist = 0.0016 Vertex 6 is not on the plane: dist = 0.0017 Vertex 7 is not on the plane: dist = 0.0026 Vertex 8 is not on the plane: dist = 0.0026 Vertex 9 is not on the plane: dist = 0.0017 Vertex 10 is not on the plane: dist = 0.0192 Vertex 11 is not on the plane: dist = 0.0182 Vertex 12 is not on the plane: dist = 0.0027 Vertex 13 is not on the plane: dist = 0.0018 Vertex 14 is not on the plane: dist = 0.0019 Vertex 15 is not on the plane: dist = 0.0028 Vertex 16 is not on the plane: dist = 0.0029 Vertex 17 is not on the plane: dist = 0.0019 Vertex 18 is not on the plane: dist = 0.0020 Vertex 19 is not on the plane: dist = 0.0018

max distance: 0.019205503129435128, so almost 2cm.

That's a complex surface too

I'm quite sure I don't want a test that actually throws in Debug mode though, I'm going to disable it.
Maybe we should talk to Autodesk about fixing the geometry there, or we need to adjust the tolerance to be more "real-world" friendly.

…n debug

jmarrec · 2023-10-16T11:37:46Z

@joseph-robertson I made a couple of changes (disabling one round trip test mostly) and left a few notes that I think we do want to address, but this is good enough to get into RC1 anyways. Letting CI run on it, then we can merge if all green.

ci-commercialbuildings · 2023-10-16T11:49:14Z

CI Results for bb8a9f3:

Ubuntu 20.04:
Ubuntu 22.04:
- OpenStudio-3.7.0-alpha+bb8a9f37a5-Ubuntu-22.04-x86_64.deb
- OpenStudio-3.7.0-alpha+bb8a9f37a5-Ubuntu-22.04-x86_64.tar.gz
Darwin:
- OpenStudio-3.7.0-alpha+bb8a9f37a5-Darwin-x86_64.dmg
- OpenStudio-3.7.0-alpha+bb8a9f37a5-Darwin-x86_64.tar.gz
Windows:
- OpenStudio-3.7.0-alpha+bb8a9f37a5-Windows.exe
- OpenStudio-3.7.0-alpha+bb8a9f37a5-Windows.tar.gz
Code Coverage:

joseph-robertson added 2 commits October 11, 2023 12:52

Update gbxmlvalidator in xmlvalidator cpp to 7.03 xsd.

b4856da

Add the 7.03 xsd to the xml resources folder.

d40c8cf

joseph-robertson added Enhancement Request component - gbXML Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Oct 11, 2023

joseph-robertson added this to the OpenStudio SDK 3.7.0 milestone Oct 11, 2023

joseph-robertson self-assigned this Oct 11, 2023

joseph-robertson added 11 commits October 11, 2023 13:24

Update xsd and version in FT.

f8fceca

Add 703 gbxml example to resources folder.

72728f2

Try validating the new example file.

869c484

Try reverse translating the new example file.

35e415b

Formatting.

dbda3b1

Missed a variable.

cd15f16

Confirm that new xml is valid.

139077f

Try a few more v703 xml files.

f818249

Formatting.

03ba0fc

Update number of errors for one new xml.

5ddb8b5

Check errors after RT and then FT.

c94807c

joseph-robertson commented Oct 12, 2023

View reviewed changes

joseph-robertson marked this pull request as ready for review October 12, 2023 16:49

joseph-robertson requested a review from jmarrec October 12, 2023 16:49

jmarrec mentioned this pull request Oct 16, 2023

gbXML 7.03 #4983

Closed

19 tasks

jmarrec added 2 commits October 16, 2023 12:43

Break RoundTrip gbxml tests in individual tests

ad2d18e

Use a parametrized fixture for the Roundtrip tests

203b0f7

jmarrec requested changes Oct 16, 2023

View reviewed changes

Disable Building_Central_Conceptual_Model roundtrip test, it throws i…

bb8a9f3

…n debug

jmarrec merged commit 6d120d4 into develop Oct 16, 2023
2 checks passed

jmarrec deleted the gbxml-7_03 branch October 16, 2023 12:25

joseph-robertson mentioned this pull request Oct 26, 2023

update gbXML to 7.03 #4966

Closed

joseph-robertson linked an issue Oct 26, 2023 that may be closed by this pull request

update gbXML to 7.03 #4966

Closed

jmarrec mentioned this pull request Jul 15, 2024

Show displayname in grid view openstudiocoalition/OpenStudioApplication#612

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gbXML schema to v7.03 #4995

Update gbXML schema to v7.03 #4995

joseph-robertson commented Oct 11, 2023 •

edited

Loading

joseph-robertson Oct 12, 2023

joseph-robertson Oct 12, 2023

jmarrec Oct 16, 2023

joseph-robertson Oct 12, 2023

jmarrec Oct 16, 2023

joseph-robertson Oct 12, 2023

joseph-robertson Oct 12, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec Oct 16, 2023

jmarrec commented Oct 16, 2023

ci-commercialbuildings commented Oct 16, 2023 •

edited

Loading

		::openstudio::embedded_files::extractFile(":/xml/resources/GreenBuildingXML_Ver7.03.xsd", openstudio::toString(tmpDir), quiet);
		return XMLValidator(tmpDir / "GreenBuildingXML_Ver7.03.xsd");

Update gbXML schema to v7.03 #4995

Update gbXML schema to v7.03 #4995

Conversation

joseph-robertson commented Oct 11, 2023 • edited Loading

Pull request overview

Pull Request Author

Review Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented Oct 16, 2023

ci-commercialbuildings commented Oct 16, 2023 • edited Loading

joseph-robertson commented Oct 11, 2023 •

edited

Loading

ci-commercialbuildings commented Oct 16, 2023 •

edited

Loading