#4957 - Some copy constructors aren't declared in SWIG #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ane and Transformation
jmarrec
added
Developer Issue
component - Utilities Geometry
Pull Request - Ready for CI
jmarrec
commented
Sep 5, 2023
Comment on lines
+30
to
+34
| // Copy and move operators are implicitly declared, but we want the copy ctor for SWIG so we have to define all of them | ||
| Point3d(const Point3d& other) = default; | ||
| Point3d(Point3d&& other) noexcept = default; | ||
| Point3d& operator=(const Point3d&) = default; | ||
| Point3d& operator=(Point3d&&) noexcept = default; |
There was a problem hiding this comment.
Put back the copy ctor for swig. Have to declare all of them or the move operations are implicitly deleted
| @@ -118,10 +118,23 @@ Surface3d::Surface3d(std::vector<Point3d> t_vertices, std::string t_name, size_t | |||
| itnext = std::begin(vertices); | |||
| } | |||
|
|
|||
| edges.emplace_back(*it, *itnext, t_name, t_surfNum); | |||
| edges.emplace_back(*it, *itnext, name, surfNum); | |||
There was a problem hiding this comment.
Fix an unrelated issue, t_name (the parameter) was moved from, so it's generally an empty string.
| @@ -164,6 +166,7 @@ using PolyhedronVector = std::vector<Polyhedron>; | |||
|
|
|||
| /// ostream operator | |||
| UTILITIES_API std::ostream& operator<<(std::ostream& os, const Surface3dEdge& edge); | |||
| UTILITIES_API std::ostream& operator<<(std::ostream& os, const Surface3d& surface3d); | |||
There was a problem hiding this comment.
Add an ostream operator<< for convenience
| @@ -138,6 +138,8 @@ class UTILITIES_API Polyhedron | |||
| * proportion of conflicted edges / total number of edges */ | |||
| std::vector<Surface3d> findSurfacesWithIncorrectOrientation() const; | |||
|
|
|||
| std::vector<Surface3d> surface3ds() const; | |||
There was a problem hiding this comment.
Convenience getter for inspection / debugging in Polyhedron
Comment on lines
+172
to
+178
| %extend openstudio::Surface3d { | ||
| std::string __str__() const { | ||
| std::ostringstream os; | ||
| os << *self; | ||
| return os.str(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Use the new Surface3d::operator<< in the swig interface file
|
CI Results for f9d1e88:
|
shorowit
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Note: The missing swig copy ctors were never in any official release, this was only on 3.7.0-alpha, so I'm labeling as "Developer Issue"
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.