LoadProfilePlant: new Fluid Type and Degree of SubCooling fields #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
added
Pull Request - Ready for CI
26 tasks
More detailed data documentation
jmarrec
requested changes
Sep 4, 2023
src/energyplus/ForwardTranslator/ForwardTranslateLoadProfilePlant.cpp
Outdated
Show resolved
Hide resolved
…ane and Transformation
…ry_directory more than 1000 times it fails...
The static std::atomic<int> was never reset to 0.
```
1001.times { OpenStudio::XMLValidator.new('./HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml') }
[openstudio.XMLValidator] <-1> Saved transformed XSLT Stylesheet at '/tmp/xmlvalidation-2b1f-69c6-900c-7b06-1693932780-998/EPvalidator_stylesheet.xslt'.
[openstudio.XMLValidator] <-1> Transformed Schematron to an XSLT Stylesheet and saved it at /tmp/xmlvalidation-2b1f-69c6-900c-7b06-1693932780-998/EPvalidator_stylesheet.xslt.
[openstudio.XMLValidator] <-1> Treating schema as a Schematron, converting to an XSLT StyleSheet.
[openstudio.XMLValidator] <-1> Saved transformed XSLT Stylesheet at '/tmp/xmlvalidation-4a67-fcb1-a651-fa6d-1693932780-999/EPvalidator_stylesheet.xslt'.
[openstudio.XMLValidator] <-1> Transformed Schematron to an XSLT Stylesheet and saved it at /tmp/xmlvalidation-4a67-fcb1-a651-fa6d-1693932780-999/EPvalidator_stylesheet.xslt.
[openstudio.XMLValidator] <-1> Treating schema as a Schematron, converting to an XSLT StyleSheet.
[openstudio.XMLValidator] <2> Failed to create a temporary directory for extracting the stylesheets needed to transform the Schematron './HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml'
Traceback (most recent call last):
8: from /usr/local/bin/irb:23:in `<main>'
7: from /usr/local/bin/irb:23:in `load'
6: from /usr/local/lib/ruby/gems/2.7.0/gems/irb-1.2.6/exe/irb:11:in `<top (required)>'
5: from (irb):70
4: from (irb):70:in `times'
3: from (irb):70:in `block in irb_binding'
2: from (irb):70:in `new'
1: from (irb):70:in `initialize'
RuntimeError (/srv/jenkins/openstudio/git/nightly/ubuntu_2004/src/utilities/xml/XMLValidator.cpp@180 : Failed to create a temporary directory for extracting the stylesheets needed to transform the Schematron './HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml')
```
#4957 - Some copy constructors aren't declared in SWIG
Fix issue in create_temporary_directory (affecting XMLValidator with schematron)
jmarrec
approved these changes
Sep 8, 2023
| LoadProfilePlant lpp(m); | ||
| EXPECT_TRUE(pl.addDemandBranchForComponent(lpp)); | ||
|
|
||
| EXPECT_TRUE(lpp.setPeakFlowRate(0.005)); |
There was a problem hiding this comment.
Nitpick, but I think we should test all fields while we're at it. Couple of extra lines only
…tsideRevealDepth Fix #4926 - WindowPropertyFrameAndDivider: "Outside Reveal Depth" not forward translated
jmarrec
reviewed
Sep 11, 2023
| EXPECT_TRUE(lpp.setLoadSchedule(scheduleConstant1)); | ||
| EXPECT_TRUE(lpp.setPeakFlowRate(0.005)); | ||
| ScheduleConstant scheduleConstant2(m); | ||
| EXPECT_TRUE(hpp.setFLowRateFractionSchedule(scheduleConstant2)); |
|
CI Results for 20a4618:
|
jmarrec
reviewed
Sep 28, 2023
Comment on lines
+233
to
+235
| setPlantLoopFluidType("Water"); | ||
| setDegreeofSubCooling(5.0); | ||
| setDegreeofLoopSubCooling(20.0); |
jmarrec
added a commit
that referenced
this pull request
Sep 28, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
LoadProfile:Plant:Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.