Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v23.2.0-IOFreeze #4940

Merged
merged 193 commits into from
Sep 28, 2023
Merged

Update to v23.2.0-IOFreeze #4940

merged 193 commits into from
Sep 28, 2023

Conversation

joseph-robertson
Copy link
Collaborator

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.7.0 milestone Aug 24, 2023
@joseph-robertson joseph-robertson added IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Aug 25, 2023
jmarrec and others added 12 commits August 28, 2023 16:21
joseph-robertson and others added 23 commits September 19, 2023 09:42
@joseph-robertson
Wrong comments.
31710b3
@jmarrec
Update src/osversion/VersionTranslator.cpp
0b43f96
@jmarrec
Make Capacity Fraction Schedule required-field (alwaysOnContinuousSch…
e03655f 
…edule)

The grand protector of the API has spoken! cf @kbenne 's comment here: #4954 (comment)
@jmarrec
Merge pull request #4970 from NREL/parasitic-load
c3a9fb2 
Coil:Heating:*: on and off cycle name changes
@jmarrec
VT test for Making Capacity Fraction Schedule non optional
426ab13
@jmarrec
VT for Making Capacity Fraction Schedule non optional
3747954 
I got pwned by making the `discreteSchHandleStr` a static string inside the lambda: try to VT two models with the same VersionTranslator instance and you're screwed. Thanks tests!
@jmarrec
Merge remote-tracking branch 'origin/v23.2.0-IOFreeze' into v23.2.0-I…
57fea8f 
…OFreeze-RenameDistrictHeating
@jmarrec
Merge pull request #4972 from NREL/v23.2.0-IOFreeze-RenameDistrictHea…
830ad7e 
…ting

V23.2.0-IOFreeze - wrap `DistrictHeating:Steam` and rename `DistrictHeating` to `DistrictHeatingWater`
@joseph-robertson
Merge branch 'v23.2.0-IOFreeze' into controller-outdoor-air
53bc50c
@joseph-robertson
Make new field a required field.
d8bd66e
@joseph-robertson
Follow convention of required getter.
c75430a
@joseph-robertson
Add vt since this new field is required.
dae4e9e
@joseph-robertson
Formatting.
2cd649e
@joseph-robertson
Fix return type in cpp.
0a5e651
@jmarrec
Merge pull request #4948 from NREL/controller-outdoor-air
455fc44 
ControllerOutdoorAir: new Economizer Operation Staging field
@joseph-robertson
Deprecate parasitic electric load in favor of better name.
9b40ed0
@joseph-robertson
Update tests and ft.
bb67829
@jmarrec
Merge remote-tracking branch 'origin/develop' into v23.2.0-IOFreeze
29ddbb6 
Resolve conflicts manually
@joseph-robertson
Make on cycle parasitic electric load required field.
99c1e13
@joseph-robertson
Minor cleanup.
920756a
@joseph-robertson
Merge branch 'v23.2.0-IOFreeze' into boiler-hot-water2
5097dc1
@jmarrec
Minor nitpicks
0b79413
@jmarrec
Merge pull request #4985 from NREL/boiler-hot-water2
9b40f51 
BoilerHotWater: on cycle name change
@jmarrec jmarrec marked this pull request as ready for review September 27, 2023 23:56
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 28, 2023 •
edited
Loading

Ok, time to drop the hammer. This builds and tests fine. Merging to develop, this will simplify our dev workflow and allow us to be more reactive and run reg tests more easily.

There's an E+ RC1 out, might become official, but there may be an RC2 as well.

I'm going to wait for CI to come clean one last time, then hit the merge button

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Sep 28, 2023 •
edited
Loading

CI Results for 96bbb76:

@jmarrec jmarrec merged commit 4b32a3b into develop Sep 28, 2023
2 checks passed
@jmarrec jmarrec deleted the v23.2.0-IOFreeze branch September 28, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrec jmarrec jmarrec left review comments

Assignees

@jmarrec jmarrec

@joseph-robertson joseph-robertson

Labels
IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
OpenStudio SDK 3.7.0
Development

Successfully merging this pull request may close these issues.

Update to EnergyPlus 23.2.0
3 participants
@joseph-robertson @jmarrec @ci-commercialbuildings