Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4737 - Replace sprintf usage with fmt::format #4902

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix #4737 - Replace sprintf usage with fmt::format #4902

merged 1 commit into from
Jun 20, 2023

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 31, 2023

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Airflow Network labels May 31, 2023
@jmarrec jmarrec added this to the OpenStudio SDK 3.7.0 milestone May 31, 2023
@jmarrec jmarrec self-assigned this May 31, 2023
@jmarrec jmarrec requested a review from tijcolem May 31, 2023 10:28
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented May 31, 2023 •
edited
Loading

CI Results for 1a76c75:

@tijcolem tijcolem merged commit 93b47f4 into develop Jun 20, 2023
@tijcolem tijcolem deleted the 4737_contam_sprintf branch June 20, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tijcolem tijcolem tijcolem approved these changes

Assignees

@jmarrec jmarrec

Labels
component - Airflow Network Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
OpenStudio SDK 3.7.0
Development

Successfully merging this pull request may close these issues.

Contam throws Wdeprecated-declarations for use of sprintf on modern clang
3 participants
@jmarrec @ci-commercialbuildings @tijcolem