Fix #4897 - openstudiolib.dll/libopenstudiolib.so not found without C++ API Component selected in IFW

[jmarrec]

Pull request overview

• Fix openstudiolib.dll not found without C++ API installation #4897
• CLI is no longer self-contained so need to install openstudiolib as part of the CLI component for IFW

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[ci-commercialbuildings]

CI Results for b67f9cc:

• Ubuntu 20.04:

  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Ubuntu-20.04-x86_64.tar.gz
  • perf_test/results.html

• Ubuntu 22.04:

  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Darwin-x86_64.dmg
  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Windows.exe
  • OpenStudio-3.7.0-alpha+b67f9cc7ec-Windows.tar.gz

• Code Coverage:

[MatthewSteen]

• 🪟 Windows 10.
• 🐈 Ubuntu 22.04 haven't tried it but can if needed.

Looks like there are two errors for the Windows build; one unrelated, one related.

2249/3807 Test #2251: ModelFixture.ScheduleFile ..........................................................................................................................................................................................................***Failed    0.17 sec
Running main() from C:\J\w\BuildSingleReference@4\.conan\data\gtest\1.11.0\_\_\build\5ad274d83035c78ba2b205e6cf4f1b317aee8e05\source_subfolder\googletest\src\gtest_main.cc
Note: Google Test filter = ModelFixture.ScheduleFile
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ModelFixture
[ RUN      ] ModelFixture.ScheduleFile
D:\git\OpenStudio\src\model\test\ScheduleInterval_GTest.cpp(264): error: Value of: externalfile
  Actual: false
Expected: true
[  FAILED  ] ModelFixture.ScheduleFile (59 ms)
[----------] 1 test from ModelFixture (59 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (60 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ModelFixture.ScheduleFile

 1 FAILED TEST

3635/3807 Test #3642: OpenStudioCLI.Labs.test_logger_rb ..................................................................................................................................................................................................***Failed    1.64 sec
Namespace(labs=True, logger_file=WindowsPath('D:/git/OpenStudio/src/cli/test/logger_test.rb'), os_cli_path=WindowsPath('D:/git/OpenStudio/build/Products/openstudio.exe'))
Running: D:\git\OpenStudio\build\Products\openstudio.exe labs execute_ruby_script D:\git\OpenStudio\src\cli\test\logger_test.rb
0 [test] <0> Warn
1 [test] <1> Error
2 [test] <1> Error
3 LOGGER - STDOUT Warn
4 LOGGER - STDOUT Error
Traceback (most recent call last):
  File "D:/git/OpenStudio/src/cli/test/run_test_logger.py", line 54, in <module>
    raise IOError(f"Expected 3 lines, got {n}")
OSError: Expected 3 lines, got 5```

[jmarrec]

Looks like there are two errors for the Windows build; one unrelated, one related.

None are related. We need to fix these tests, it's annoying to have to dig through to see if it's something new or something broken already