Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ElectricEquipmentITEAirCooledDefinition's "Watts per Zone Floor Area" and replace with "Watts per Space Floor Area" #5103

Closed
jmarrec opened this issue Mar 11, 2024 · 4 comments · Fixed by #5105

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 11, 2024

Enhancement Request

Deprecate ElectricEquipmentITEAirCooledDefinition's "Watts per Zone Floor Area" and replace with "Watts per Space Floor Area"

Detailed Description

cf #5090 (comment)

Possible Implementation

Straightforward.

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 11, 2024

The schedules should never have been optional, but defaulted to always on:

// Return the Design Power Input Schedule. If not specified, default to always 1.
boost::optional<Schedule> designPowerInputSchedule() const;
bool isDesignPowerInputScheduleDefaulted() const;
// Return the CPU Loading Schedule. If not specified, default to always 1.
boost::optional<Schedule> cPULoadingSchedule() const;
bool isCPULoadingScheduleDefaulted() const;

but this would be an API break now

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 11, 2024

Seems like the "Number of Units" field was omitted from the implementation. I think it's replaced by Multiplier to match other objects

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 11, 2024

All other SpaceLoadInstances use the same terminology powerPerFloorArea / getPowerPerFloorArea but this one doesn't, it uses wattsperZoneFloorArea

@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 11, 2024

Setters don't clear the other field. setWattsperFloorArea should clear the Watts Per Unit one, and vice versa

@jmarrec jmarrec self-assigned this Mar 11, 2024
jmarrec added a commit that referenced this issue Mar 11, 2024
…r Zone Floor Area" and replace with "Watts per Space Floor Area"
jmarrec added a commit that referenced this issue Mar 22, 2024
Fix #5103 - ElectricEquipmentITEAirCooled / ElectricEquipmentITEAirCooledDefinition - align objects with other SpaceLoads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment