WaterToAirHeatPumpEquationFit curves do not support Table:Lookup

[mleachNREL]

Issue overview

CoilCoolingWaterToAirHeatPumpEquationFit and CoilHeatingWaterToAirHeatPumpEquationFit do not support specifying curve data using Table:Lookup.

They are supposed to accept \reference QuadvariateFunctions but the documentation shows only that Curve:QuadLinear and Curve:QuintLinear are allowed for their respective curve fields

Recreate the issue - see attached script

Context

This is needed for ComStock GSHP measure development
coil_bug.rb.txt

[joseph-robertson]

Perhaps bool setTotalCoolingCapacityCurve(const CurveQuadLinear& totalCoolingCapacityCurve); needs to be relaxed to something like bool setTotalCoolingCapacityCurve(const Curve& totalCoolingCapacityCurve);?

Probably need to inventory all objects where curve type is too exclusive.

[joseph-robertson]

This issue is probably a lot like #4611.

[jmarrec]

I agree with you @joseph-robertson

• Change the type to the more generic Curve. Important: This is an unavoidable API break and should be documented properly
• Make sure the IDD references are up to date
• Look at E+ source code to make sure that there aren't more restrictions on what's accepted, if so implement them in the setter

Edit: I see you already started a PR, leaving it up to you then.