Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setAmbientTemperatureSchedule and setAmbientAirVelocitySchedule setter for PipeIndoor do not work #4894

Closed
lymereJ opened this issue May 24, 2023 · 0 comments · Fixed by #4901
Closed

setAmbientTemperatureSchedule and setAmbientAirVelocitySchedule setter for PipeIndoor do not work #4894

lymereJ opened this issue May 24, 2023 · 0 comments · Fixed by #4901
Assignees
@jmarrec
Labels
component - HVAC component - Model severity - Minor Bug

Comments

@lymereJ
Copy link

lymereJ commented May 24, 2023

Issue overview

The PipeIndoor's setAmbientTemperatureSchedule and setAmbientAirVelocitySchedule setters don't appear to work. I'm getting the following error when trying to use them: [openstudio.model.ScheduleTypeRegistry] <2> No 'Ambient Temperature Schedule' Schedule is registered for class PipeIndoor..

Steps to Reproduce

model = OpenStudio::Model::Model.new
pipe = OpenStudio::Model::PipeIndoor.new(model)
pipe.setAmbientTemperatureSchedule(model.alwaysOnDiscreteSchedule)

Environment

  • Platform: Windows 11
  • Version of OpenStudio: 3.6

Context

I'm using the setPointer workaround but it would be nice if if the setters could work.
@lymereJ lymereJ added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label May 24, 2023
@jmarrec jmarrec self-assigned this May 31, 2023
jmarrec added a commit that referenced this issue May 31, 2023
@jmarrec
Write proper tests for PipeIndoor (failing due to #4894)
c9be6c7 
unknown file: Failure
C++ exception with description "/Users/julien/Software/Others/OpenStudio/src/model/ScheduleTypeRegistry.cpp@68 : No 'Ambient Temperature Schedule' Schedule is registered for class PipeIndoor." thrown in the test body.
jmarrec added a commit that referenced this issue May 31, 2023
@jmarrec
Fix #4894 - PipeIndoor ScheduleTypeRegistry typo
3c0c4db
@jmarrec jmarrec added severity - Minor Bug component - HVAC component - Model and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels May 31, 2023
@jmarrec jmarrec mentioned this issue May 31, 2023
Merged
19 tasks
jmarrec added a commit that referenced this issue Jun 29, 2023
@jmarrec
Merge pull request #4901 from NREL/4894_PipeIndoor
f731007 
#4894 - `setAmbientTemperatureSchedule` and `setAmbientAirVelocitySchedule` setter for `PipeIndoor` do not work
@eringold eringold mentioned this issue Oct 4, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - HVAC component - Model severity - Minor Bug
Projects
None yet
Milestone
No milestone
2 participants
@lymereJ @jmarrec