Update GroundHeatExchangerHorizontalTrench: wrap Site:GroundTemperature:Undisturbed:XXX objects #4734
Labels
APIChange
A motivated non-backward compatible change that breaks the existing API and needs to be communicated
component - HVAC
component - Version Translator
Enhancement Request
Milestone
Enhancement Request
Following #4716 , the GroundHeatExchangerHorizontalTrench is outdated:
SiteGroundTemperature
but that isn't even functionalSite:GroundTemperature:Undisturbed:KusudaAchenbach
, theSite:GroundTemperature:Undisturbed:Xing
andSite:GroundTemperature:Undisturbed:FiniteDifference
aren't possible optionsDetailed Description
Possible Implementation
Option B proposed by @joseph-robertson on #4717 (comment)
Wrap
Site:GroundTemperature:Undisturbed:KusudaAchenbach
for starters (FiniteDifference and Xing could be done later)Deprecate the getters / setters (with a clear message saying it'll be removed in 3.8.0 or something).
If we were to wrap the Xing/FiniteDifference, these would just throw if it's not Kusuda (pseudo-code):
I agree with Joe: Existing Ctor would create a KusudaAchenbach for you. Make a second ctor where you pass in the ground model object.
Requires VT.
The text was updated successfully, but these errors were encountered: