Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in ExternalFile placement #3317

Closed
macumber opened this issue Oct 18, 2018 · 1 comment
Closed

Error in ExternalFile placement #3317

macumber opened this issue Oct 18, 2018 · 1 comment
Assignees
@macumber
Labels
component - Model severity - Normal Bug

Comments

@macumber
Copy link
Contributor

macumber commented Oct 18, 2018 •
edited
Loading

When copying an ExternalFIle, the destination should be the first path returned by WorkflowJSON::absoluteFilePaths rather than the root dir:

OpenStudio/openstudiocore/src/model/ExternalFile.cpp

Line 221 in 9885686

path rootDir = workflow.absoluteRootDir();

See https://docs.google.com/document/d/1NB3m0aNDSA-womkN8r7cS4DpB36uZO3qpf-UeWoITUU/edit#
@macumber macumber self-assigned this Oct 18, 2018
@macumber
Copy link
Contributor Author

Related to #3297

macumber added a commit that referenced this issue Oct 18, 2018
@macumber
Fixes #3317
e8fd0b1
macumber added a commit that referenced this issue Nov 4, 2018
@macumber
Merge pull request #3322 from NREL/Issue3317
923deca 
Fixes #3317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macumber macumber

Labels
component - Model severity - Normal Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macumber