Fix #8822 - new warning to explain why Standard62.1Summary may not be available in Output:Table:SummaryReports #8831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Jun 18, 2021
Comment on lines
1697
to
1707
| if (UtilityRoutines::SameString(AlphArray(iReport), "Standard62.1Summary")) { | ||
| ShowWarningError(state, | ||
| format("{} Field[{}]=\"Standard62.1Summary\", Report is not enabled.", CurrentModuleObject, iReport)); | ||
| ShowContinueError(state, "Do Zone Sizing or Do System Sizing must be enabled in SimulationControl."); | ||
|
|
||
| } else { | ||
| ShowSevereError( | ||
| state, | ||
| format("{} Field[{}]=\"{}\", invalid report name -- will not be reported.", CurrentModuleObject, iReport, AlphArray(iReport))); | ||
| // ErrorsFound=.TRUE. | ||
| } |
There was a problem hiding this comment.
New warning to explain.
There was a problem hiding this comment.
ref code :
EnergyPlus/src/EnergyPlus/OutputReportPredefined.cc
Lines 935 to 937 in e936516
Comment on lines
+9784
to
+9798
| TEST_F(EnergyPlusFixture, OutputReportTabularTest_PredefinedTable_Standard62_1_NoSizing) | ||
| { | ||
| // Test for #8822 - new warning to explain why Standard62.1 report is not enabled | ||
| std::string const idf_objects = delimited_string({ | ||
| "Output:Table:SummaryReports,", | ||
| " Standard62.1Summary; !- Report 1 Name", | ||
| }); | ||
|
|
||
| ASSERT_TRUE(process_idf(idf_objects)); | ||
|
|
||
| // These are already set to these values, but be explicit. | ||
| // Because DoZoneSizing and DoSystemSizing are both false Standard62.1Summary is **not** enabled | ||
| state->files.outputControl.tabular = true; | ||
| state->dataGlobal->DoZoneSizing = false; | ||
| state->dataGlobal->DoSystemSizing = false; |
There was a problem hiding this comment.
Test that the warning is issued when sizing calcs are NOT requested
Comment on lines
+9819
to
+9832
| TEST_F(EnergyPlusFixture, OutputReportTabularTest_PredefinedTable_Standard62_1_WithSizing) | ||
| { | ||
| // Test for #8822 - ensures that when Zone/System sizing is requested, the report is there and the warning isn't. | ||
| std::string const idf_objects = delimited_string({ | ||
| "Output:Table:SummaryReports,", | ||
| " Standard62.1Summary; !- Report 1 Name", | ||
| }); | ||
|
|
||
| ASSERT_TRUE(process_idf(idf_objects)); | ||
|
|
||
| // Because DoZoneSizing is true Standard62.1Summary **is** enabled | ||
| state->files.outputControl.tabular = true; | ||
| state->dataGlobal->DoZoneSizing = true; | ||
| state->dataGlobal->DoSystemSizing = false; |
There was a problem hiding this comment.
Test that the warning is NOT issued when sizing calcs are requested
jmarrec
commented
Jun 18, 2021
Comment on lines
+400
to
+404
| The Standard 62.1 Summary (key: Standard62.1Summary) produces a report that is consistent with many of the outputs needed when doing calculations consistent with ASHRAE Standard 62.1-2010. | ||
|
|
||
| \textbf{Note: The report is only generated when sizing calculations are specified.}: in \hyperref[simulationcontrol]{SimulationControl}, ``Do Zone Sizing'' or ``Do System Sizing'' must be set to ``Yes''. | ||
|
|
||
| The abbreviations used in the report are consistent with the abbreviations used in Appendix A4 of the Standard. The following tables are part of the report: |
Comment on lines
+2754
to
+2758
| This report is more fully described in the Input Output Reference. The Standard 62.1 Summary produces a report that is consistent with many of the outputs needed when doing calculations consistent with ASHRAE Standard 62.1-2010. | ||
|
|
||
| The abbreviations used in the report are consistent with the abbreviations used in Appendix A4 of the Standard. Directly following is an example of the report. The key used to obtain this report is Standard62.1Summary. | ||
|
|
||
| \textbf{Note: The report is only generated when sizing calculations are specified.}: in \hyperref[simulationcontrol]{SimulationControl}, ``Do Zone Sizing'' or ``Do System Sizing'' must be set to ``Yes''. |
20 tasks
|
@jmarrec I was going to start reviewing this but noticed that it had some formatting checks failing. Can you fix those and the merge conflict? Thanks. |
|
@JasonGlazer Merged develop and clang-formatted. |
|
Thanks @jmarrec |
|
This is ready to be merged. |
|
Thanks for the review @JasonGlazer ! |
mjwitte
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.