Global HeatingCoils, DualDuct, DataPhotovoltaics & Fix #8635

[dareumnam]

Pull request overview

• Moves HeatingCoils, DualDuct, and DataPhotovoltaics to state
• Quick Fix for Wrong comparison in an if statement in Photovoltaics.cc #8635

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

@dareumnam the CI diffs are unrelated to your changes. I'll get clean results and we'll see if this can go in.

[Myoldmopar]

I pulled develop into your branch. There weren't any conflicts, but I obviously still built it and everything built just fine. I am running regressions now, but I was able to reproduce the unit test problem that shows up even on develop. It's nothing your branch did, and I'll fix it separately. If regressions are good here I'll merge this in.

[Myoldmopar]

Regressions all looked perfect. Merging this one in too, great!