Global HVACManager, HVACMultiSpeedHeatPump, and HVACDXHeatPumpSystem

[dareumnam]

Pull request overview

Moved HVACManager, HVACMultiSpeedHeatPump, and HVACDXHeatPumpSystem to state

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[dareumnam]

constexpr is used instead of enum class since these values are compared with integer values of parameters that are describing coil types in DataHVACGlobals for now.

[Myoldmopar]

Pulled develop in locally and building and testing. This will go next if it is all good.

[Myoldmopar]

The three build warnings that were showing up on Mac are not there in my local build anymore, as expected, since they were addressed in develop by now. Build and unit tests are good to go. Waiting on fresh develop build to finish in a few minutes then I'll run some regressions. I anticipate this merging in 15 minutes. I will then pull develop into my own globals branch and get it pushed and merged, and switch back over to non-globals PRs for a bit.

[Myoldmopar]

Ran 300 regression files and zero diffs at all. Everything is good here, merging this in. Thanks @dareumnam !