Global OutputReportTabular

[mitchute]

Pull request overview

• Moves OutputReportTabular to state

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

The Linux/Windows CI machine had gone down for updates sometime so I got that rebooted and running again. CI results should start coming in soon and this can likely go right in. Thanks @mitchute!

[mitchute]

@Myoldmopar We're still missing Windows results here. Did that CI go down again?

[mitchute]

This is ready as far as I can tell. However, my local Windows build is failing.

fatal error C1128: number of sections exceded object file format limit: compile with /bigobj

And it also looks like the Windows CI is struggling since it hasn't reported any results here. We should probably wait until #8425 goes in before merging this.

[jasondegraw]

@mitchute I'm seeing that same error now locally on develop on the energypluslib and energyplus_tests projects. If OpenStudio history serves as a guide, it'll be machine and compiler dependent in weird ways, so I'd suggest that the flag be added pretty soon.

[mitchute]

My Windows VM is happy with this now that #8438 is included. Also, for the interested reader, we discovered that a unit test failure was introduced into develop (Test_UnitaryHybridAirConditioner_Unittest). The fix for this has already been incorporated here so CI should be 100% happy again. Assuming that happens, this can be merged anytime thereafter.

[Myoldmopar]

👍