-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove round trim cleanup formatting #8379
Conversation
* Remove the RoundSigDigits and TrimSigDigits functions * They were over used and misused for integer->string conversions * Merge any string concatenations that used Round/Trim functions into libfmt operations * Overall binary is ~2% smaller * Diff set still needs to be formatted
This is going to be great. I'll keep an eye on it for when CI is happy with it and you feel like you are done with it. |
@Myoldmopar I'm clearly quite confused on this as of course I've been building it all along on my systems and it's not building at all on any CI. I'll see what's going on. |
Definitely closer, but Windows is still having trouble with an ambiguous |
I'll resolve the conflicts here and get this ready to go. Thanks for fixing the |
Sorry, I missed the conflicts. I headed out of town for a couple of days |
I'm not sure why CI complained on the unit test coverage build, but the AFN error message diff is definitely fixing an erroneous error message here: https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/AirflowNetwork/src/Properties.cpp#L85 We'll keep an eye on CI for this next round of results and go from there. |
Yes, I saw many minor mistakes during the conversion that I left because I didn't want to cause too many diffs, but when I saw this mistake which was 100% wrong, I felt I needed to fix it (it's mentioned in the PR also) |
Thanks, @lefticus. This is looking really good. I'll try to get this one in right away so we don't keep having to deal with merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to see these cleaned up!
I see the coverage dipped very slightly because of lines changed here. I don't anticipate artificially pumping that back up or adjusting the limit, we'll leave the warning and try to bump it back up through other PRs. This looks otherwise good on CI with the one expected diff and the GPU spurious regressions. I see this is ready and will merge, thanks! |
Pull request overview
Refactoring to remove RoundSigDigits and TrimSigDigits while adding format() calls where reasonable.
expected failure:
No other changes expected.