ZoneHVAC:HybridUnitaryHVAC ERR object type output #8326
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -468,7 +468,7 @@ namespace HybridUnitaryAirConditioners { | |
| using namespace DataIPShortCuts; // Data for field names, blank numerics | ||
| using namespace DataLoopNode; | ||
| using DataSizing::OARequirements; // to find DesignSpecification:OutdoorAir pointer | ||
| std::string cCurrentModuleObject; // Object type for getting and error messages | ||
| Array1D_string Alphas; // Alpha items for object | ||
| Array1D<Real64> Numbers; // Numeric items for object | ||
| Array1D_string cAlphaFields; // Alpha field names | ||
|
|
@@ -486,9 +486,9 @@ namespace HybridUnitaryAirConditioners { | |
|
|
||
| // SUBROUTINE PARAMETER DEFINITIONS: | ||
| static std::string const RoutineName("GetInputZoneHybridUnitaryAirConditioners: "); | ||
| cCurrentModuleObject = "ZoneHVAC:HybridUnitaryHVAC"; | ||
| NumZoneHybridEvap = inputProcessor->getNumObjectsFound(cCurrentModuleObject); | ||
| inputProcessor->getObjectDefMaxArgs(cCurrentModuleObject, NumFields, NumAlphas, NumNumbers); | ||
| int MaxNumbers = max(0, NumNumbers); // Maximum number of numeric fields in all objects | ||
| int MaxAlphas = max(0, NumAlphas); // Maximum number of alpha fields in all objects | ||
| Alphas.allocate(MaxAlphas); | ||
|
|
@@ -506,7 +506,7 @@ namespace HybridUnitaryAirConditioners { | |
|
|
||
| for (UnitLoop = 1; UnitLoop <= NumZoneHybridEvap; ++UnitLoop) { | ||
| inputProcessor->getObjectItem(state, | ||
| cCurrentModuleObject, | ||
| UnitLoop, | ||
| Alphas, | ||
| NumAlphas, | ||
|
|
@@ -521,7 +521,7 @@ namespace HybridUnitaryAirConditioners { | |
| IsNotOK = false; | ||
| IsBlank = false; | ||
| UtilityRoutines::VerifyName( | ||
| Alphas(1), ZoneHybridUnitaryAirConditioner, UnitLoop - 1, IsNotOK, IsBlank, cCurrentModuleObject + " Name"); | ||
|
|
||
| // A1, \field Name | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).Name = Alphas(1); | ||
|
|
@@ -543,32 +543,40 @@ namespace HybridUnitaryAirConditioners { | |
| } | ||
|
|
||
| // A4, \field Minimum Supply Air Temperature Schedule Named | ||
| if (!lAlphaBlanks(4)) { | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).TsaMin_schedule_pointer = GetScheduleIndex(state, Alphas(4)); | ||
| if (ZoneHybridUnitaryAirConditioner(UnitLoop).TsaMin_schedule_pointer == 0) { | ||
| ShowSevereError("Invalid " + cAlphaFields(4) + '=' + Alphas(4)); | ||
| ShowContinueError("Entered in " + cCurrentModuleObject + '=' + cAlphaArgs(1)); | ||
| ErrorsFound = true; | ||
| } | ||
| } | ||
| // A5, \field Maximum Supply Air Temperature Schedule Name | ||
| if (!lAlphaBlanks(5)) { | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).TsaMax_schedule_pointer = GetScheduleIndex(state, Alphas(5)); | ||
| if (ZoneHybridUnitaryAirConditioner(UnitLoop).TsaMax_schedule_pointer == 0) { | ||
| ShowSevereError("Invalid " + cAlphaFields(5) + '=' + Alphas(5)); | ||
| ShowContinueError("Entered in " + cCurrentModuleObject + '=' + cAlphaArgs(1)); | ||
|
There was a problem hiding this comment. Made a test file with bad inputs in a bunch of fields, and some of the error messages are still broken:
|
||
| ErrorsFound = true; | ||
| } | ||
| } | ||
| // A6, \field Minimum Supply Air Humidity Ratio Schedule Name | ||
| if (!lAlphaBlanks(6)) { | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).RHsaMin_schedule_pointer = GetScheduleIndex(state, Alphas(6)); | ||
| if (ZoneHybridUnitaryAirConditioner(UnitLoop).RHsaMin_schedule_pointer == 0) { | ||
| ShowSevereError("Invalid " + cAlphaFields(6) + '=' + Alphas(6)); | ||
| ShowContinueError("Entered in " + cCurrentModuleObject + '=' + cAlphaArgs(1)); | ||
| ErrorsFound = true; | ||
| } | ||
| } | ||
| // A7, \field Maximum Supply Air Humidity Ratio Schedule Name | ||
| if (!lAlphaBlanks(7)) { | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).RHsaMax_schedule_pointer = GetScheduleIndex(state, Alphas(7)); | ||
| if (ZoneHybridUnitaryAirConditioner(UnitLoop).RHsaMax_schedule_pointer == 0) { | ||
| ShowSevereError("Invalid " + cAlphaFields(7) + '=' + Alphas(7)); | ||
| ShowContinueError("Entered in " + cCurrentModuleObject + '=' + cAlphaArgs(1)); | ||
| ErrorsFound = true; | ||
| } | ||
| } | ||
|
|
||
| // A8, \field Method to Choose Value of Controlled Inputs | ||
|
|
@@ -578,21 +586,21 @@ namespace HybridUnitaryAirConditioners { | |
| // A11, \field Supply Air Node Name | ||
| // A12, \field Relief Node Name | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).InletNode = GetOnlySingleNode(state, | ||
| Alphas(9), ErrorsFound, cCurrentModuleObject, Alphas(1), NodeType_Air, NodeConnectionType_Inlet, 1, ObjectIsNotParent); | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).SecondaryInletNode = GetOnlySingleNode(state, Alphas(10), | ||
| ErrorsFound, | ||
| cCurrentModuleObject, | ||
| Alphas(1), | ||
| NodeType_Air, | ||
| NodeConnectionType_OutsideAirReference, | ||
|
There was a problem hiding this comment. This is kind of nit-picky, but |
||
| 1, | ||
| ObjectIsNotParent); | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).OutletNode = GetOnlySingleNode(state, | ||
| Alphas(11), ErrorsFound, cCurrentModuleObject, Alphas(1), NodeType_Air, NodeConnectionType_Outlet, 1, ObjectIsNotParent); | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).SecondaryOutletNode = GetOnlySingleNode(state, | ||
| Alphas(12), ErrorsFound, cCurrentModuleObject, Alphas(1), NodeType_Air, NodeConnectionType_ReliefAir, 1, ObjectIsNotParent); | ||
| TestCompSet(cCurrentModuleObject, Alphas(1), Alphas(9), Alphas(11), "Hybrid Evap Air Zone Nodes"); | ||
| TestCompSet(cCurrentModuleObject, Alphas(1), Alphas(10), Alphas(12), "Hybrid Evap Air Zone Secondary Nodes"); | ||
|
|
||
| // N1, \field System Maximum Supply AirFlow Rate | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).SystemMaximumSupplyAirFlowRate = Numbers(1); | ||
|
|
@@ -643,13 +651,15 @@ namespace HybridUnitaryAirConditioners { | |
| // A18, \field Objective Function Minimizes | ||
|
|
||
| // A19, \ OA requirement pointer | ||
| if (!lAlphaBlanks(19)) { | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).OARequirementsPtr = UtilityRoutines::FindItemInList(Alphas(19), OARequirements); | ||
| if (ZoneHybridUnitaryAirConditioner(UnitLoop).OARequirementsPtr == 0) { | ||
| ShowSevereError(RoutineName + cCurrentModuleObject + " = " + Alphas(1) + " invalid data"); | ||
| ShowContinueError("Invalid-not found " + cAlphaFields(19) + "=\"" + Alphas(19) + "\"."); | ||
| ErrorsFound = true; | ||
| } else { | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).OutdoorAir = true; | ||
| } | ||
| } | ||
|
|
||
| int FirstModeAlphaNumber = 20; | ||
|
|
@@ -673,7 +683,7 @@ namespace HybridUnitaryAirConditioners { | |
| } | ||
| } | ||
| // add the ZoneHVAC:HybridUnitaryHVAC Scaled Maximum Supply Air Volume Flow Rate to the Component Sizing Report Summary | ||
| BaseSizer::reportSizerOutput(cCurrentModuleObject, | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).Name, | ||
| "Scaled Maximum Supply Air Volume Flow Rate [m3/s]", | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).ScaledSystemMaximumSupplyAirVolumeFlowRate); | ||
|
|
@@ -683,16 +693,16 @@ namespace HybridUnitaryAirConditioners { | |
| // setup output variables | ||
| for (UnitLoop = 1; UnitLoop <= NumZoneHybridEvap; ++UnitLoop) { | ||
|
|
||
| SetUpCompSets(cCurrentModuleObject, | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).Name, | ||
| cCurrentModuleObject, | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).Name, | ||
| NodeID(ZoneHybridUnitaryAirConditioner(UnitLoop).InletNode), | ||
| NodeID(ZoneHybridUnitaryAirConditioner(UnitLoop).OutletNode)); | ||
|
|
||
| SetUpCompSets(cCurrentModuleObject, | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).Name, | ||
| cCurrentModuleObject, | ||
| ZoneHybridUnitaryAirConditioner(UnitLoop).Name, | ||
| NodeID(ZoneHybridUnitaryAirConditioner(UnitLoop).SecondaryInletNode), | ||
| NodeID(ZoneHybridUnitaryAirConditioner(UnitLoop).SecondaryOutletNode)); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IDD has this as a required field so I just removed the statement about leaving the field blank.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. But the code for this input is wrong. See comment below.