-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test file ASHRAE9012016_Hospital_Denver problem with hard size of zone exhaust and outdoor air ventilation #8882
Comments
@JasonGlazer I wanted to point this out during 10x call today. I suspect it is why that file is an outlier in testing. |
Note that these files are getting updated in #8686. I have not looked to see if this issue is addressed there. |
Very interesting @EnergyArchmage. So we randomly picked a poor file to do the 10x testing. |
I just ran the new version of the file from #8686 with my custom e+ and get the same error message. The kitchen zone is severely starved and the air loop serving it is going to operate erratically. |
@EnergyArchmage - Would you mind sharing the name of the branch that you are using to generate these warnings? |
Sorry, it isn't a public repo. I'll see if client wants to contribute that bit of code. |
@EnergyArchmage - Thanks for sharing the branch that you are using to generate this new warning messages! I took a look at the code changes and at the model. It appears that, for this particular file, what the warning shows will never occur because the kitchen exhaust fan is off between midnight and 7am. The code in the PR shows that its retrieving the minimum value of the schedule used to represent the hourly balanced exhaust fraction and use it to determine the balanced air flow fraction. For that model, the schedule is 0 between midnight and 7am so it is assumed that none of the exhaust flow is actually balanced. However, this is not really true because the fan will never operate during these hours. I changed the fraction from 0 to 1 for that period and the warning changes to the following which shows that the exhaust and ventilation requirement are virtually the same. Let me know if I'm missing something here, otherwise we'll modify #8686 to make sure that the exhaust flow and requirements are exactly the same (I believe that the same warning for the corridor is due to a rounding error in the input file) so the warning does not pop up.
|
@jungwyoungs made some changes to the models in #8686 to address the warnings generated by #8886. The balanced air flow fraction schedules that were using a fraction of 0 when the exhaust fans are scheduled to be off were changed to 1. This removed most of the warnings. The remaining were due to some very small discrepancies in inputs (one example is the warning for the corridor shown above) and were also addressed. |
Issue overview
The integration test file ASHRAE9012016_Hospital_Denver has two zones with exhaust fans with airflow rates that exceed the outdoor air requirements for the zone. This causes problems in modeling make up air and return air flows in the central air handler. The file is often an outlier in integration testing outcomes and this issue is a likely cause.
A custom warning message created to help catch these sorts of input problems generates these errors for this file.
Details
Some additional details for this issue (if relevant):
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
The text was updated successfully, but these errors were encountered: