Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDF file causing segfault #10555

Closed
3 tasks
egreyadsk opened this issue Jun 10, 2024 · 8 comments
Closed
3 tasks

IDF file causing segfault #10555

egreyadsk opened this issue Jun 10, 2024 · 8 comments

Comments

@egreyadsk
Copy link

Issue overview

The attached IDF file is causing a segfault. It takes a couple hours before the error happens.

Details

Some additional details for this issue (if relevant):

  • Windows 10 Enterprise
  • 23.1.0-87ed9199d4

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added in.zip
  • Ticket added to EnergyPlus Defect Complexity (Github Project)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@egreyadsk
Copy link
Author

@marklemay @MatthewSteen FYI, this is logged by Autodesk.

@jmarrec
Copy link
Contributor

jmarrec commented Jun 11, 2024

I don't think anyone is especially looking forward to waiting for a couple of hours to reproduce a crash.
Especially if you consider that if you attach a debugger, you're running in debug mode, so that's going to be like 10 hours waiting to catch a stacktrace.

@egreyadsk , can you please provide any additional information?
stdout/stderr + eplusout.err would be great if possible.

When does it happen? During Sizing? During the annual runperiod? If so, which months? Can we reproduce by just running a couple of days around that time?

@mjwitte
Copy link
Contributor

mjwitte commented Jun 11, 2024

This looks similar to #10490 but this doesn't have more spaces than zones, so it can't have more solar enclosure than zone. It does trip on the same convexity assert, but that's a side note. I'll run this with the branch for #10498 to see if and where it fails there.

@mjwitte
Copy link
Contributor

mjwitte commented Jun 11, 2024

I can confirm that the file runs to completion with a release build of the branch for #10498, which is good yet puzzling.
@marklemay Does this idf have interior windows?

@mjwitte
Copy link
Contributor

mjwitte commented Jun 13, 2024

Found the problem, and it was fixed in v24.1. In v23.1 it fails with a stack overflow when the old QsortC function tried to sort the meter names, all 16,311 of them in this file. This function was replaced with a map in #10347, thanks @amirroth !

How are there so many meters? There are 1393 spaces and 1393 zones. These generate a lot of submeters for both spaces and zones. I can't think of a workaround for v23.1 other than reducing the number of spaces and zones. Or move to v24.1.

@mjwitte mjwitte closed this as completed Jun 13, 2024
@egreyadsk
Copy link
Author

Thanks @mjwitte and @jmarrec for looking at this.

@MatthewSteen
Copy link
Member

@egreyadsk this fix will be included in the next build of the OpenStudio CLI For Revit (OpenStudio 3.8.0, EnergyPlus 24.1) since it was fixed in EP 24.1.

@egreyadsk
Copy link
Author

Thanks @MatthewSteen, that's good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants