Skip to content

Commit

Permalink
auto to const auto& while I'm at it
Browse files Browse the repository at this point in the history
  • Loading branch information
jmarrec committed Dec 3, 2020
1 parent 55646d2 commit f6888ab
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions third_party/Windows-CalcEngine/src/Gases/src/Gas.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace Gases {
m_Properties( t_Gas.m_Properties ), m_DefaultGas( t_Gas.m_DefaultGas ),
m_Pressure( t_Gas.m_Pressure ) {
m_GasItem.clear();
for ( auto item : t_Gas.m_GasItem ) {
for ( auto const &item : t_Gas.m_GasItem ) {
m_GasItem.push_back( item );
}
}
Expand All @@ -39,7 +39,7 @@ namespace Gases {
double CGas::totalPercent() {
auto totalPercent = 0.0;

for ( auto& it : m_GasItem ) {
for ( auto const &it : m_GasItem ) {
totalPercent += it.getFraction();
}

Expand Down

5 comments on commit f6888ab

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-MacOS-10.15-clang-11.0.0: OK (2993 of 2994 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 718
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3032 of 3034 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: EIO diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 1 test had: Table big diffs.

Failures:\n

integration Test Summary

  • Passed: 721
  • Failed: 1

regression Test Summary

  • Passed: 736
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1558 of 1558 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2249 of 2250 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 718
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Coverage Too Low

Failures:\n

integration Test Summary

  • Passed: 721
  • Failed: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.