Skip to content

Commit

Permalink
address warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
@brianlball
brianlball committed Aug 24, 2020
1 parent abde03d commit 8d3da42
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
6 changes: 3 additions & 3 deletions src/EnergyPlus/WeatherManager.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2971,7 +2971,7 @@ namespace WeatherManager {
}

Real64
CalcSkyEmissivity(EnergyPlusData &state, EmissivityCalcType const ESkyCalcType, Real64 const OSky, Real64 const DryBulb, Real64 const DewPoint, Real64 const RelHum)
CalcSkyEmissivity(EnergyPlusData &EP_UNUSED(state), EmissivityCalcType const ESkyCalcType, Real64 const OSky, Real64 const DryBulb, Real64 const DewPoint, Real64 const RelHum)
{
// Calculate Sky Emissivity
// References:
Expand Down Expand Up @@ -3878,7 +3878,7 @@ namespace WeatherManager {

//------------------------------------------------------------------------------

void ASHRAETauModel(EnergyPlusData &state, DesignDaySolarModel const TauModelType, // ASHRAETau solar model type ASHRAE_Tau or ASHRAE_Tau2017
void ASHRAETauModel(EnergyPlusData &EP_UNUSED(state), DesignDaySolarModel const TauModelType, // ASHRAETau solar model type ASHRAE_Tau or ASHRAE_Tau2017
Real64 const ETR, // extraterrestrial normal irradiance, W/m2
Real64 const CosZen, // COS( solar zenith angle), 0 - 1
Real64 const TauB, // beam tau factor
Expand Down Expand Up @@ -7943,7 +7943,7 @@ namespace WeatherManager {
}
}

void SkipEPlusWFHeader(EnergyPlusData &state, IOFiles &ioFiles)
void SkipEPlusWFHeader(EnergyPlusData &EP_UNUSED(state), IOFiles &ioFiles)
{

// SUBROUTINE INFORMATION:
Expand Down
19 changes: 9 additions & 10 deletions src/EnergyPlus/WeatherManager.hh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,9 @@ namespace WeatherManager {
Real64 AirMass(Real64 CosZen); // COS( solar zenith), 0 - 1

// Calculate sky temperature from weather data
Real64 CalcSkyEmissivity(EnergyPlusData &state, EmissivityCalcType ESkyCalcType, Real64 OSky, Real64 DryBulb, Real64 DewPoint, Real64 RelHum);
Real64 CalcSkyEmissivity(EnergyPlusData &EP_UNUSED(state), EmissivityCalcType ESkyCalcType, Real64 OSky, Real64 DryBulb, Real64 DewPoint, Real64 RelHum);

void ASHRAETauModel(EnergyPlusData &state, DesignDaySolarModel TauModelType, // ASHRAETau solar model type ASHRAE_Tau or ASHRAE_Tau2017
void ASHRAETauModel(EnergyPlusData &EP_UNUSED(state), DesignDaySolarModel TauModelType, // ASHRAETau solar model type ASHRAE_Tau or ASHRAE_Tau2017
Real64 ETR, // extraterrestrial normal irradiance, W/m2
Real64 CosZen, // COS( solar zenith angle), 0 - 1
Real64 TauB, // beam tau factor
Expand Down Expand Up @@ -718,7 +718,7 @@ namespace WeatherManager {

void ProcessEPWHeader(EnergyPlusData &state, IOFiles &ioFiles, std::string const &HeaderString, std::string &Line, bool &ErrorsFound);

void SkipEPlusWFHeader(EnergyPlusData &state, IOFiles &ioFiles);
void SkipEPlusWFHeader(EnergyPlusData &EP_UNUSED(state), IOFiles &ioFiles);

void ReportMissing_RangeData(EnergyPlusData &state);

Expand Down Expand Up @@ -1153,7 +1153,8 @@ namespace WeatherManager {

// Default Constructor
WeatherManagerData()
: Sigma(5.6697e-8),
: GetBranchInputOneTimeFlag(true), GetEnvironmentFirstCall(true), PrntEnvHeaders(true), FirstCall(true),
WaterMainsParameterReport(true), PrintEnvrnStamp(false), Sigma(5.6697e-8),
YearOfSim(1), NumDaysInYear(365), EnvironmentReportNbr(0), EnvironmentReportChr(""),
WeatherFileExists(false),
LocationGathered(false), WeatherFileLatitude(0.0), WeatherFileLongitude(0.0),
Expand All @@ -1166,12 +1167,10 @@ namespace WeatherManager {
NumDataPeriods(0), NumIntervalsPerHour(1), UseDaylightSaving(true), UseSpecialDays(true),
UseRainValues(true), UseSnowValues(true), EPWDaylightSaving(false), IDFDaylightSaving(false),
DaylightSavingIsActive(false), WFAllowsLeapYears(false),
curSimDayForEndOfRunPeriod(0), Envrn(0), NumOfEnvrn(0), NumEPWTypExtSets(0),
NumWPSkyTemperatures(0), GetBranchInputOneTimeFlag(true), GetEnvironmentFirstCall(true), FirstCall(true),
PrntEnvHeaders(true), RptIsRain(0), RptIsSnow(0), RptDayType(0), HrAngle(0.0),
SolarAltitudeAngle(0.0), SolarAzimuthAngle(0.0), HorizIRSky(0.0), TimeStepFraction(0.0),
NumSPSiteScheduleNamePtrs(0), WaterMainsParameterReport(true),
EndDayOfMonth(12, {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}), PrintEnvrnStamp(false),
curSimDayForEndOfRunPeriod(0), Envrn(0), NumOfEnvrn(0), NumEPWTypExtSets(0), NumWPSkyTemperatures(0),
RptIsRain(0), RptIsSnow(0), RptDayType(0), HrAngle(0.0),
SolarAltitudeAngle(0.0), SolarAzimuthAngle(0.0), HorizIRSky(0.0), TimeStepFraction(0.0),
NumSPSiteScheduleNamePtrs(0), EndDayOfMonth(12, {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}),
LeapYearAdd(0), DatesShouldBeReset(false),
StartDatesCycleShouldBeReset(false), Jan1DatesShouldBeReset(false), RPReadAllWeatherData(false)
{
Expand Down

7 comments on commit 8d3da42

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (13 of 13 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - x86_64-MacOS-10.15-clang-11.0.0: OK (2900 of 2921 tests passed, 0 test warnings)

Failures:\n

API Test Summary

  • Passed: 4
  • Failed: 5

integration Test Summary

  • Passed: 702
  • Failed: 16

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2939 of 2961 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: EIO diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 1 test had: Table big diffs.

Failures:\n

API Test Summary

  • Passed: 4
  • Failed: 5

integration Test Summary

  • Passed: 705
  • Failed: 16

regression Test Summary

  • Passed: 735
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1482 of 1487 tests passed, 0 test warnings)

Failures:\n

API Test Summary

  • Passed: 4
  • Failed: 5

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - Win64-Windows-10-VisualStudio-16: OK (2164 of 2180 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 702
  • Failed: 16

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_weather_manager2 (brianlball) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (705 of 721 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 705
  • Failed: 16

Build Badge Test Badge Coverage Badge

Please sign in to comment.