Skip to content

Commit

Permalink
MSVC Warning adjustments
Browse files Browse the repository at this point in the history
  • Loading branch information
lefticus committed Dec 17, 2020
1 parent 46e6d43 commit 56ce95e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/ConvertInputFormat/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
cmake_minimum_required(VERSION 3.5.1)
project(ConvertInputFormat)

# set(CMAKE_CXX_STANDARD 11)

# Set the CFLAGS and CXXFLAGS depending on the options the user specified.
# Only GCC-like compilers support -Wextra, and other compilers give tons of
# output for -Wall, so only -Wall and -Wextra on GCC.
Expand Down
4 changes: 4 additions & 0 deletions third_party/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
# we link the project_options in here for every library in this
# subdirectory

set(CMAKE_CXX_STANDARD 17)

if (NOT MSVC)
add_compile_options(-Wno-pedantic -Wno-unused-parameter)
else()
add_compile_options(/wd4267 /wd4996 /wd4068 /wd4244 )
endif()

set(INSTALL_GTEST CACHE BOOL OFF)
Expand Down

4 comments on commit 56ce95e

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_modernize (lefticus) - x86_64-MacOS-10.15-clang-11.0.0: OK (2997 of 2997 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_modernize (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3037 of 3037 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_modernize (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1563 of 1563 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_modernize (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (720 of 721 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 720
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.