Skip to content

Commit

Permalink
Fix more apply-clang 12.0 warnings (Wrange-loop-analysis)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmarrec committed Dec 3, 2020
1 parent 65489a9 commit 55646d2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tst/EnergyPlus/unit/OutputProcessor.unit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3434,7 +3434,7 @@ namespace OutputProcessor {

ReportingFrequency report_freq = ReportingFrequency::EachCall;

for (auto const option : valid_options) {
for (auto const &option : valid_options) {
report_freq = determineFrequency(*state, option.first);
EXPECT_EQ(option.second, report_freq);
}
Expand Down Expand Up @@ -4032,7 +4032,7 @@ namespace OutputProcessor {
{17, std::make_tuple(2, "MYBUILDINGOTHER", "Electricity", "", "", "", "J")},
});

for (auto const result : meters_result) {
for (auto const &result : meters_result) {
EXPECT_EQ(std::get<0>(result.second), EnergyMeters(result.first).TypeOfMeter);
EXPECT_EQ(std::get<1>(result.second), EnergyMeters(result.first).Name);
EXPECT_EQ(std::get<2>(result.second), EnergyMeters(result.first).ResourceType);
Expand Down Expand Up @@ -4082,7 +4082,7 @@ namespace OutputProcessor {
{6, std::make_tuple(0, "GeneralLights:InteriorLights:Electricity", "Electricity", "InteriorLights", "GeneralLights", "", "J")},
});

for (auto const result : meters_result) {
for (auto const &result : meters_result) {
EXPECT_EQ(std::get<0>(result.second), EnergyMeters(result.first).TypeOfMeter);
EXPECT_EQ(std::get<1>(result.second), EnergyMeters(result.first).Name);
EXPECT_EQ(std::get<2>(result.second), EnergyMeters(result.first).ResourceType);
Expand Down

5 comments on commit 55646d2

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-MacOS-10.15-clang-11.0.0: OK (2993 of 2994 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 718
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1558 of 1558 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3032 of 3034 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: EIO diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 1 test had: Table big diffs.

Failures:\n

integration Test Summary

  • Passed: 721
  • Failed: 1

regression Test Summary

  • Passed: 736
  • Failed: 1

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2249 of 2250 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 718
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8312_build_warnings_v2 (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Coverage Too Low

Failures:\n

integration Test Summary

  • Passed: 720
  • Failed: 1
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.