Skip to content

Commit

Permalink
move EvapCoolerType ints to enum and move from DataGlobalConstants to…
Browse files Browse the repository at this point in the history
… EvaporativeCoolers
  • Loading branch information
mitchute committed Oct 11, 2020
1 parent 52146b6 commit 2d501c8
Show file tree
Hide file tree
Showing 5 changed files with 72 additions and 84 deletions.
16 changes: 0 additions & 16 deletions src/EnergyPlus/DataGlobalConstants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -303,22 +303,6 @@ namespace DataGlobalConstants {
int const iGeneratorWindTurbine(7);
int const iGeneratorPVWatts(8);

int const iEvapCoolerDirectCELDEKPAD(1001);
int const iEvapCoolerInDirectCELDEKPAD(1002);
int const iEvapCoolerInDirectWETCOIL(1003);
int const iEvapCoolerInDirectRDDSpecial(1004);
int const iEvapCoolerDirectResearchSpecial(1005);

// DERIVED TYPE DEFINITIONS:
// na

// MODULE VARIABLE DECLARATIONS:
// na

// SUBROUTINE SPECIFICATIONS FOR MODULE DataGlobalConstants

// Functions

int AssignResourceTypeNum(std::string const &ResourceTypeChar)
{

Expand Down
8 changes: 1 addition & 7 deletions src/EnergyPlus/DataGlobalConstants.hh
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,6 @@ namespace DataGlobalConstants {
extern int const iGeneratorWindTurbine;
extern int const iGeneratorPVWatts;

extern int const iEvapCoolerDirectCELDEKPAD;
extern int const iEvapCoolerInDirectCELDEKPAD;
extern int const iEvapCoolerInDirectWETCOIL;
extern int const iEvapCoolerInDirectRDDSpecial;
extern int const iEvapCoolerDirectResearchSpecial;

enum class CallIndicator {
BeginDay,
DuringDay,
Expand Down Expand Up @@ -286,7 +280,7 @@ namespace DataGlobalConstants {
Real64 constexpr MaxEXPArg () { return 709.78; } // maximum exponent in EXP() function
Real64 constexpr Pi () { return 3.14159265358979324; } // Pi 3.1415926535897932384626435
Real64 constexpr PiOvr2 () { return Pi() / 2.0; } // Pi/2
Real64 constexpr TwoPi () { return 2.0 * Pi(); } // 2*Pi 6.2831853071795864769252868r
Real64 constexpr TwoPi () { return 2.0 * Pi(); } // 2*Pi 6.2831853071795864769252868
Real64 constexpr GravityConstant () { return 9.807; }
Real64 constexpr DegToRadians () { return Pi() / 180.0; } // Conversion for Degrees to Radians
Real64 constexpr RadToDeg () { return 180.0 / Pi(); } // Conversion for Radians to Degrees
Expand Down
Loading

4 comments on commit 2d501c8

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_dataGlobals_2_again (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Build Failed

Failures:\n

integration Test Summary

  • Passed: 2
  • Failed: 720

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_dataGlobals_2_again (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: Build Failed

Failures:\n

API Test Summary

  • Failed: 6
  • notrun: 3

integration Test Summary

  • Passed: 2
  • Failed: 720

regression Test Summary

  • Passed: 735
  • Failed: 2

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_dataGlobals_2_again (mitchute) - x86_64-MacOS-10.15-clang-11.0.0: OK (2983 of 2984 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 718
  • Failed: 1

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_dataGlobals_2_again (mitchute) - Win64-Windows-10-VisualStudio-16: OK (2239 of 2240 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 718
  • Failed: 1

Build Badge Test Badge

Please sign in to comment.