Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider loading the system by default in get_decision_problem_results #1144

Open
GabrielKS opened this issue Sep 20, 2024 · 1 comment
Open
Assignees

Comments

@GabrielKS
Copy link
Contributor

Very minor interface change: a while ago, we added to the get_decision_problem_results a keyword argument to populate the system:

uc = get_decision_problem_results(results, "UC"; populate_system = true)

. We made it default to false for backwards compatibility, but a few times now I've fielded questions from people who forget to attach the system and then wonder why their analytics aren't working. Now that we serialize the system to the HDF5 container so it is always present, I propose we make populate_system default to true in the next breaking release. We can keep the option to opt out for special cases.

@jd-lara
Copy link
Member

jd-lara commented Sep 21, 2024

agree you can open a PR with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants