Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some leftover 2.0 problems #9

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Fix some leftover 2.0 problems #9

merged 5 commits into from
Mar 30, 2023

Conversation

josephmckinsey
Copy link

@josephmckinsey josephmckinsey commented Mar 23, 2023

Somehow the sequel to #5

I have also added a bit more testing and fixed the github actions.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +10.42 🎉

Comparison is base (20ad529) 77.92% compared to head (07f509a) 88.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   77.92%   88.34%   +10.42%     
===========================================
  Files           3        3               
  Lines         308      309        +1     
===========================================
+ Hits          240      273       +33     
+ Misses         68       36       -32     
Flag Coverage Δ
unittests 88.34% <100.00%> (+10.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fuel_results.jl 96.55% <100.00%> (+0.12%) ⬆️
src/get_data.jl 86.80% <100.00%> (+12.79%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jd-lara
Copy link
Member

jd-lara commented Mar 30, 2023

@josephmckinsey is this PR ready to merge?

@jd-lara jd-lara self-assigned this Mar 30, 2023
@josephmckinsey josephmckinsey marked this pull request as ready for review March 30, 2023 17:49
@josephmckinsey josephmckinsey requested review from jd-lara and removed request for claytonpbarrows March 30, 2023 17:49
@jd-lara jd-lara merged commit e0c4147 into main Mar 30, 2023
@jd-lara jd-lara deleted the jm/missed-2.0-updates branch March 30, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants