Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for release 0.6.0 #57

Closed
Shaquu opened this issue Mar 8, 2019 · 20 comments
Closed

Preparing for release 0.6.0 #57

Shaquu opened this issue Mar 8, 2019 · 20 comments
Labels
help wanted Used for setup help

Comments

@Shaquu
Copy link
Member

Shaquu commented Mar 8, 2019

From a while we were adding more to dev branch. It's time to finally make it to release 0.6.0.

What I need from you is to test it AGAIN and report it as below.

Calling contributors but all are welcome to help!
@radokristof @crxporter @flic @radionoise @emilingerslev

PS. If I missed something then shout!

@Shaquu Shaquu added the help wanted Used for setup help label Mar 8, 2019
@Shaquu Shaquu assigned Shaquu and unassigned Shaquu Mar 8, 2019
@Shaquu Shaquu added this to the Release 0.6.0 milestone Mar 8, 2019
@radokristof
Copy link
Contributor

No_Response should work on every valid characteristics?

@Shaquu
Copy link
Member Author

Shaquu commented Mar 8, 2019

I think it should work for all valid REQUIRED characteristics.

@crxporter
Copy link
Member

I thought all was good then I noticed an issue with linked services and backwards compatibility. It appears all of the items that were in my system before updating are shown as "linked services" instead of "parent services" after updating to the dev branch. This doesn't seem to break anything - but it could cause confusion for people upgrading and wanting to add linked services...

I think pre-existing items should become parent services in 0.6.0


My other notes:

Starting from a working install of 0.5.1 I added in all of the examples from the wiki page and tested before updating to 0.6.0.

All items worked pre-update.

Backwards compatibility check: all items passed. No errors updating from 0.5.1 to dev branch.

Adding in NO_RESPONSE works on all required characteristics.

The example I made this morning of AirPurifier with all features and linked filter service works.

onIdentify works properly.

I'm not using mdns config so I can't test that - but it's not breaking anything.

Tested everything both on and off wifi (through apple tv hub) - no issues.

@crxporter
Copy link
Member

Another interesting thing happening - deleting items from node red used to make them disappear immediately from the Home app.

This is not happening on 0.6.0 - seems to now be required to restart node-red for deleted items to be removed from the Home app.

@radokristof
Copy link
Contributor

@crxporter In my opinion this should be the next priority, to work out somehow so that we don't have to restart node-red every time, just deploy to detect changes (add items, delete items, change items...).

@crxporter
Copy link
Member

Generally if you add an item just once and hit "deploy modified nodes" things will work just fine without restart. As long as you don't hit "deploy" when the homekit nodes have been modified everything is fine and dandy.

Adding new items works fine without a node-red restart. Just don't run a full deploy.

Even deleting used to work without a restart of node-red... I just noticed today with 0.6.0 that it's not working properly.

@Shaquu
Copy link
Member Author

Shaquu commented Mar 9, 2019

Thanks for comments :)

So one by one.

  1. Services should be default isParent set to true. It's strange that you have it set to Linked Service at default... Hmm. Are you sure you were testing last dev? I will check.
  2. Fixing bugs correlated with need to restart node-red to make it work will be a main feature of next release (0.7.0). I really hate those bugs ;/
  3. MDNS looks like not working. Got to fix it...

@flic
Copy link
Contributor

flic commented Mar 10, 2019

Sorry I'm a bit late! Filter on topic works fine on the dev-branch.

@Shaquu
Copy link
Member Author

Shaquu commented Mar 10, 2019

@flic thanks for confirmation!

@crxporter please check newest dev for fix for default value Parent when moving to version 0.6 - should now work. Backward compatibility is highest priority.

@crxporter
Copy link
Member

Off to install the 0.5 and run the update again... Stay tuned.

@crxporter
Copy link
Member

LGTM - 0.5 nodes default to parent service in 0.6.

Just missing the NO_RESPONSE from @radionoise now, right? It's still working the "old way" before his new PR.

@Shaquu
Copy link
Member Author

Shaquu commented Mar 10, 2019 via email

@Shaquu
Copy link
Member Author

Shaquu commented Mar 13, 2019

Last checks guys!
I am planning to make a release tomorrow evening so we can head to more important stuff like bugs...
I hope nothing brakes :|

@crxporter
Copy link
Member

Just updated to node-red 0.20.0 and installed a fresh dev branch.

I updated a different node through the palette manager and for some reason I was put back on 0.5.1 - but replacing the folder again got me right back to "everything looks good"

No new problems here on 0.6.0 or node-red 0.20.0.

@radokristof
Copy link
Contributor

@Shaquu are you planing to push 0.6 to master today?

@Shaquu
Copy link
Member Author

Shaquu commented Mar 14, 2019

@radokristof I would like to do it but we need to retest Linked/Parent Services again due to changes in #41
So if you have time then please test it (mainly backward compatibility).
@crxporter are you there?

PS. So I assume it will happen tomorrow if you help me ;)

@crxporter
Copy link
Member

No new errors here. Upgrading / downgrading / upgrading leaves things a bit confused but adding new stuff works as expected. 0.5 services load in properly so backwards compatibility is still good.

I'm sure users will find something else but hey- that's what 0.6.1 is for, right?!

Tested on node-red 0.20.1.

@crxporter
Copy link
Member

PS - I'll be adding a comment on my openhab post about this plugin once 0.6 is released so that those users know to come use linked services. I know there's several people watching that thread more closely than anything over here...

@Shaquu
Copy link
Member Author

Shaquu commented Mar 15, 2019

Okay working on the merge. Thank you all!

@Shaquu Shaquu closed this as completed Mar 15, 2019
@Shaquu
Copy link
Member Author

Shaquu commented Mar 15, 2019

We are online!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Used for setup help
Projects
None yet
Development

No branches or pull requests

4 participants