Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraneous GSD_ in number concentration variable names #972

Closed
SamuelTrahanNOAA opened this issue Jun 12, 2024 · 7 comments · Fixed by #974
Closed

extraneous GSD_ in number concentration variable names #972

SamuelTrahanNOAA opened this issue Jun 12, 2024 · 7 comments · Fixed by #974

Comments

@SamuelTrahanNOAA
Copy link
Contributor

SamuelTrahanNOAA commented Jun 12, 2024

The number concentration variables begin with "GSD_" which implies they're model-specific:

  • GSD_NCRAIN_ON_HYBRID_LVL
  • GSD_NCCD_ON_HYBRID_LVL
  • GSD_NCIP_ON_HYBRID_LVL

They're simply the number concentration. Nothing to do with GSD.

I suggest we add synonym variables (ie. NCRAIN_ON_HYBRID_LEVEL) and deprecate the GSD_ versions.

@WenMeng-NOAA's preference is to rename the variables and not add synonyms. This will require updating model workflows to use new *.txt files with the correct names.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA You might update UPP IDs 747,752,754 with

  • NCRAIN_ON_HYBRID_LVL
  • NCCD_ON_HYBRID_LVL
  • NCIP_ON_HYBRID_LVL

@SamuelTrahanNOAA
Copy link
Contributor Author

You might update UPP IDs 747,752,754 with

Is there any way that could break existing model workflows?

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA No, the RRFS workflow has been using the branch 'release/rrfs_v1' aiming RRFS v1 implementation. Your PR will merged to the 'develop' branch for future implementations.

@SamuelTrahanNOAA
Copy link
Contributor Author

Okay. I'll update my branch to do what you suggest (merely rename the variables). Presently, I'm arguing with the inline post, trying to get it to run with the latest UPP. Your suggestion will be in the next round of testing.

@WenMeng-NOAA
Copy link
Collaborator

Okay. I'll update my branch to do what you suggest (merely rename the variables). Presently, I'm arguing with the inline post, trying to get it to run with the latest UPP. Your suggestion will be in the next round of testing.

@SamuelTrahanNOAA There might be more efforts to get inline post working at UFS side with the latest UPP, e.g. g2tmpl, inline post interface. Let's get your changes working in offline post first. Thanks!

@SamuelTrahanNOAA
Copy link
Contributor Author

My changes already work in the offline post, and I have a fix for the inline post. I expect to have it working shortly, probably today.

@jaymes-kenyon
Copy link
Contributor

@SamuelTrahanNOAA — Just wanted to say thanks for removing the unnecessary "GSD_" prefixes from the number-concentration shortnames. My PR in Aug 2023 (#758) added the number concentrations to RRFS output, but I did not seize the opportunity to drop the "GSD_" designations. Simplified code is always welcomed—thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants