Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib needs to be corrected to CMAKE_INSTALL_LIBDIR #146

Closed
aerorahul opened this issue Jul 22, 2022 · 4 comments · Fixed by #152
Closed

lib needs to be corrected to CMAKE_INSTALL_LIBDIR #146

aerorahul opened this issue Jul 22, 2022 · 4 comments · Fixed by #152
Assignees
Labels
build Building software can be complicated

Comments

@aerorahul
Copy link
Contributor

set(CONFIG_INSTALL_DESTINATION lib/cmake/${PROJECT_NAME})

On x64, the library is installed in lib64 while the cmake config file is in lib.

Note.
Its likely this is happening in other nceplibs as well.

@edwardhartnett
Copy link
Contributor

@aerorahul what should be done about this? Sorry, I'm not the CMake expert that Kyle was...

@aerorahul
Copy link
Contributor Author

The above line should be replaced with:

set(CONFIG_INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME})

i.e. lib should be replaced with ${CMAKE_INSTALL_LIBDIR}

@AlexanderRichert-NOAA
Copy link
Contributor

@edwardhartnett @aerorahul I'm just getting caught up on this. To be clear, is the goal to have the cmake config land in the same directory as the library? In the case of bacio, the static library destination is being set in src/CMakeLists.txt in the "ARCHIVE DESTINATION lib" line, so using CMAKE_INSTALL_DIR will not guarantee that the cmake files end up in the same directory.

@edwardhartnett
Copy link
Contributor

Let's talk about bacio under the bacio project. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Building software can be complicated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants