Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed package to conform to CMD check #160

Merged
merged 19 commits into from
Oct 18, 2024
Merged

Fixed package to conform to CMD check #160

merged 19 commits into from
Oct 18, 2024

Conversation

andybeet
Copy link
Member

@andybeet andybeet commented Oct 18, 2024 •
edited
Loading

Moved content from root

To data-raw:

  • workshop folder - old rmds used in synthesis meetings
  • chunk-scripts folder - old scripts used in above rmds. replaced by plot functions

To man/figures

  • ecodata1.gif - used in readme

rmds

  • Link to new gif location with updated syntax in readme.rmd
  • added Rcmd badge to readme.rmd
  • changed data_requirements.rmd to a vignette format rather than html

Function fixes

  • Added missing argument definitions for geoms and themes
  • Fixed issues with examples not running

NOTE : Still need to fix documentation issues in plot functions and data objects

@andybeet
add rcmd check badges
cb2895c
@andybeet
moved workshop folder to data-raw
cffe89c
@andybeet
rcmd check on branch
bf602c9
@andybeet
added missing arguments in geom functions
044725d
@andybeet
do not error Rcmd on warnings or notes
c400f15
@andybeet
moved ecodata gif from root to man.figures
cc31628 
- updated readme.rmd
@andybeet
added argument definitions and fixed formatting
e028ee1
@andybeet
theme_map example fails due to missing packages. encapsulate in \dontrun
6c8c325
@andybeet
convert data_guidelines to vignette format
3a6dc6e
@andybeet
dontrun geom_regime example
4147af7
@andybeet
moved chunk-scripts to data-raw
db4877d
@andybeet
formatted data object consistently
dfd7b47 
- hp_density
- lps_sharks etc
@andybeet
added library ggplot to function example
b6caa58
@andybeet
removed function name from Suggests. Already in Imports
52ecb89
@andybeet
remove reference to hidden workshop folder. no longer needed
5b94319
@andybeet
removed missing link in long_line_survey since no entry in tech doc t…
8825cb1 
…o link to
@andybeet
added missing braces in dataset documentation
84c83b5
@andybeet
removed missing link to techdoc
798b0e1
@andybeet
run example in theme_ts
377fa6a
@andybeet andybeet linked an issue Oct 18, 2024 that may be closed by this pull request
add R-CMD workflow #159
Open
@andybeet andybeet requested a review from BBeltz1 October 18, 2024 14:40
BBeltz1
BBeltz1 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@BBeltz1 BBeltz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks passed. builds locally.

@BBeltz1 BBeltz1 merged commit 336ec17 into dev Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBeltz1 BBeltz1 BBeltz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add R-CMD workflow
2 participants
@andybeet @BBeltz1