-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove/fix prettytable-rs
dependency
#195
Comments
pineappl
segfaults in CI with ubuntu-22.04
pineappl
segfaults in CI
I can tell you that I could compile PineAPPL on my local Ubuntu 22.04, I did it many times. |
Yes, it's not quite that easy. What I noticed is that it started breaking when the switch happened, but it's still there with It seems that |
I had a look to the logs, but it is highly non-trivial. Maybe the more precise statements is about grid loading: |
True, that is even weirder. |
I can reproduce a segfault with Rust nightly, which segfaults in |
I agree it matches the observation, but is the CI running with Nightly? |
Yes, it was. It works with stable, see here: https://github.com/NNPDF/pineappl/actions/runs/3646808485/jobs/6158307245. However, I think the problem is which is the only piece marked 'unsafe'. I can confirm that this piece of code is called. |
Interestingly enough, the guy wrote: // All this is a bit hacky. Let's try to find something else on May 29, 2017, and it's still there. It looks a good candidate to break with new versions. Essentially, it is recasting an immutable reference to a table to a mutable one, to perform a single operation. But that's an entry point for plenty of issues. (and it is the only |
Ok, it seems like there is already an issue open mentioning it phsym/prettytable-rs#145. |
Yes, I'm pretty sure that's the cause. |
pineappl
segfaults in CIprettytable-rs
dependency
You can just bump prettytable-rs to 0.10 - I've pushed a release :) |
@pinkforest I'm already on it, thanks! |
Recently,
ubuntu-latest
was switched fromubuntu-20.04
toubuntu-22.04
, which seems to breakpineappl
. It segfaults, see https://github.com/NNPDF/pineappl/actions/runs/3646167214/jobs/6156975988. My bet is that it's not caused bypineappl
itself but rather by a dependency.The text was updated successfully, but these errors were encountered: