Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CommonData Reader #1678

Merged
merged 53 commits into from
Mar 4, 2024
Merged

Commits on Mar 1, 2024

  1. Groups of commit with the first on-development version of the commond…

    …ata reader
    
    new commondata reader
    
    improve the notebook
    
    remove duplicated functions
    
    make theory optional
    
    remove old style data that was included with this pr
    
    updated reader to the new (new) format
    
    some parser updates
    
    update the reader: definition->definitions, add a columns of 0s when no stat, return multiplicative uncertainties as a % for compatibility
    
    reorder in the parser
    
    handle nonstr
    
    applied suggestion for ValidOperation
    
    add check for -1 factors when they are just eigenvectors
    
    fill the mid kinematic value with the average of min and max
    
    update notebook ; allow for hepdata version to be None
    
    update notebook
    
    ignore kinematic variables beyond the 3rd one
    
    fix tests
    
    minimal set of modifications so that one can actually use the new cd in validphys actions
    
    first movements towards the deprecation of the yaml database; take the commondata as source of truth when one in the new format is read
    
    add a specific error for datasets without TheoryMetaData
    
    update commondataparser to "fake" PlotOptions
    
    separate plotting options so that they are compatible with the old-commondata plotting options, more testing needed
    
    import plotoptions
    
    use kinematic coverage to select the kinematics
    
    document a bit better each class inside the parser
    
    read kinematic_coverage as a list ; add a few checks
    
    add the transitional identity tranformation
    
    remove todo and add extra info about the self.legacy
    
    use the kinematic coverage variables for the filter
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c7a8739 View commit details
    Browse the repository at this point in the history
  2. Group of commits for the organization fo the cd reader and extra options

    Update validphys2/src/validphys/core.py
    
    Co-authored-by: Mark Nestor Costantini <[email protected]>
    
    promote the shifts flag to a first class theory flag
    
    tell the user why a given dataset could not load when the theory is missing
    
    beautify a bit the grouping labels
    
    show a verbose error when not finding pineappl fktables
    
    add the option for extra_labels
    
    fallback until we have some more datasets merged
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    25a79ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa45697 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ac79552 View commit details
    Browse the repository at this point in the history
  5. update reader for cd with less than 3 variables

    allow saving the whole kin
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a2d9f15 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8de1a50 View commit details
    Browse the repository at this point in the history
  7. change the order of the checks

    rebased on top of current master
    
    modify import
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bd56b74 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    184fc7c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9bcd4d7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1c4be0b View commit details
    Browse the repository at this point in the history
  11. implement positivity

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ab513e2 View commit details
    Browse the repository at this point in the history
  12. now the variant can also change the theory

    allow data_central in the variants...
    
    add the possibility to read integrability datasets
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7967b53 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ed62849 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2a68b9b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e604c14 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    ed65895 View commit details
    Browse the repository at this point in the history
  17. update regression tests to use new commondata ; make sure pseudodata …

    …generation is reproducible
    
    typo, - -> _
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7a68650 View commit details
    Browse the repository at this point in the history
  18. load new data when available even if old name used

    miscelaneous update for oldcommondata compatibility
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    13a4155 View commit details
    Browse the repository at this point in the history
  19. allow using pseudodata generated with old fits

    skip the names in the comparison of frames ; only vp-rebuild-data and loading fit commondata missing
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4cc602c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    a8f3ba4 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    73c1742 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    add9814 View commit details
    Browse the repository at this point in the history
  23. freeze metadata, use custom hash and lru_cache to avoid loading the s…

    …ame thing many times, make things faster with CLoader
    
    remove load_commondata_instance, use load everwhere ; freeze metadata
    
    avoid modifying the same plotting options twice
    
    use CLoader if available to speed up yaml parsing;
    
    dont use ruamel directyl
    
    Apply suggestions from code review
    
    Co-authored-by: Tanjona Rabemananjara <[email protected]>
    scarlehoff and Radonirinaunimi committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e2e00b6 View commit details
    Browse the repository at this point in the history
  24. Remove libNNPDF closure tests utilities (#1946)

    * remove old utilities for closure tests that were used for compatibility with nnfit closure tests
    
    * when writing closure test data, write the entire list of data, not only the points that pass the cuts
    
    * read/write uncertainties in closure tests
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0c58709 View commit details
    Browse the repository at this point in the history
  25. add an explicit check if number of points != number of bins in kinema…

    …tics / data / uncertainties
    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5fa05cd View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    36da497 View commit details
    Browse the repository at this point in the history
  27. Apply suggestions from code review

    Co-authored-by: Tanjona Rabemananjara <[email protected]>
    scarlehoff and Radonirinaunimi committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fc4560f View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    3a90148 View commit details
    Browse the repository at this point in the history
  29. recover the export method

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bf7d755 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    8910749 View commit details
    Browse the repository at this point in the history
  31. Apply suggestions from code review

    Co-authored-by: Roy Stegeman <[email protected]>
    scarlehoff and RoyStegeman committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b2201c2 View commit details
    Browse the repository at this point in the history
  32. more review comments

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ff21f0f View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    a18ec47 View commit details
    Browse the repository at this point in the history
  34. cleanup some files

    RoyStegeman authored and scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a626d1b View commit details
    Browse the repository at this point in the history
  35. fix docstring

    RoyStegeman committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5c65afe View commit details
    Browse the repository at this point in the history
  36. more review comments

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5cca29c View commit details
    Browse the repository at this point in the history
  37. first attempt

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4e510fc View commit details
    Browse the repository at this point in the history
  38. minimal working version

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bbacdec View commit details
    Browse the repository at this point in the history
  39. Add jets and dijets

    andreab1997 authored and scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a929df0 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    58228b3 View commit details
    Browse the repository at this point in the history
  41. Add HQP_YQ, HQP_YQQ and HQP_PTQ

    andreab1997 authored and scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c5cbfeb View commit details
    Browse the repository at this point in the history
  42. add herajet and heradijet

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    09d82da View commit details
    Browse the repository at this point in the history
  43. fix to bcdms

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1974192 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    5e0df7c View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    376ec47 View commit details
    Browse the repository at this point in the history
  46. 3.9 compatibility

    scarlehoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7e6599a View commit details
    Browse the repository at this point in the history
  47. Apply suggestions from code review

    Co-authored-by: Roy Stegeman <[email protected]>
    scarlehoff and RoyStegeman authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    00be99a View commit details
    Browse the repository at this point in the history
  48. Update validphys2/src/validphys/pineparser.py

    Co-authored-by: Tanjona Rabemananjara <[email protected]>
    scarlehoff and Radonirinaunimi authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7b8ff6d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Merge pull request #1949 from NNPDF/add_a_library_of_process_options

    Add a library of process dependent options
    scarlehoff authored Mar 3, 2024
    Configuration menu
    Copy the full SHA
    07cf9e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Apply suggestions from code review

    Co-authored-by: Roy Stegeman <[email protected]>
    scarlehoff and RoyStegeman authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c95e3a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c49c8f1 View commit details
    Browse the repository at this point in the history
  3. clean up files

    RoyStegeman committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0ada415 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    13db094 View commit details
    Browse the repository at this point in the history