Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option in AspNetRequestIpLayoutRenderer to check for X-Forwarded-For header #324

Closed
Giorgi opened this issue Oct 26, 2018 · 8 comments
Closed

Add an option in AspNetRequestIpLayoutRenderer to check for X-Forwarded-For header #324

Giorgi opened this issue Oct 26, 2018 · 8 comments
Labels
ASP.NET 4 ASP.NET MVC Classic feature
Milestone
NLog.Web + NLog.W...

Comments

@Giorgi
Copy link
Contributor

Giorgi commented Oct 26, 2018

Type (choose one):

  • Feature request

Add an option in AspNetRequestIpLayoutRenderer to check for X-Forwarded-For header. This is needed because if the server is behind a proxy the real client ip address value is in this header.
@snakefoot
Copy link
Contributor

@Giorgi PullRequests are always welcome

@Giorgi
Copy link
Contributor Author

Giorgi commented Oct 27, 2018

@snakefoot Done.

@Giorgi Giorgi mentioned this issue Oct 27, 2018
Merged
@304NotModified
Copy link
Member

closed by #325 - thanks!

@Giorgi
Copy link
Contributor Author

Giorgi commented Jan 3, 2019

@304NotModified Is there any target date for new release with this change ?

@304NotModified
Copy link
Member

@Giorgi thanks for the reminder, working now on it! #332

@304NotModified
Copy link
Member

build broken :( some config issue I think.

@304NotModified
Copy link
Member

@Giorgi publishing now! (thanks to @snakefoot !)

@304NotModified
Copy link
Member

online now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ASP.NET 4 ASP.NET MVC Classic feature
Projects
None yet
Milestone
NLog.Web + NLog.Web.AspNetCore 4.7.1
Development

No branches or pull requests
3 participants
@Giorgi @304NotModified @snakefoot