Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why named the extensions class "AspNetExtensions"? #76

Closed
kerryjiang opened this issue Dec 10, 2016 · 9 comments
Closed

Why named the extensions class "AspNetExtensions"? #76

kerryjiang opened this issue Dec 10, 2016 · 9 comments
Labels

Comments

@kerryjiang
Copy link

I don't think it's a good idea to name the extensions class as "AspNetExtensions". Because NLog also can be use in other back end applications than website.

Probably the name "NLogExtensions" would be better?

@304NotModified
Copy link
Member

304NotModified commented Dec 12, 2016

Because those extensions are only for ASPNET (core)

We will move them to NLog.web in the future

@kerryjiang
Copy link
Author

So there will be extension class for console or other backend applications?

@304NotModified
Copy link
Member

The first steps will be splitting the AspNetExtensions to aspnet and non-aspnet (generic). Not sure if there any generic helpers ATM.

For Console their aren't plans, and if we include them, they should be in another package, depending of the dependencies.

@dima117
Copy link

dima117 commented Jan 6, 2017

I have a similar question. Why this logging library has a dependency on Microsoft.AspNetCore.Hosting (though Microsoft.Extensions.Logging has not this dependence)?

I want to use NLog (via Microsoft.Extensions.Logging) in the console application and I do not need any dependencies associated with web applications.

@304NotModified
Copy link
Member

Same answer. This will be also moved to NLog.web in the future. Had no time to fix it yet. Could use some help, although NLog.web needs also an update first.

@dima117
Copy link

dima117 commented Jan 7, 2017

@304NotModified Thanks for the quick reply!
Could you say how much time it will take approximately? How can I help in this matter?

@304NotModified
Copy link
Member

304NotModified commented Jan 11, 2017

We have to do the following to remove the dependency to ASP.NET for this package

  1. document the new layout renderers (which are ASP.NET Core compatible :)) for NLog.web 4.3 - it's already in master . See Update docs for Nlog.Web 4.3 NLog.Web#64
  2. move AspNetExtensions to nlog.web and remove ASP.NET dependency.
  3. release nlog.web 4.3 with dependency to NLog.Extensions.Logging (for .NET Core)
  4. remove AspNetExtensions from NLog.Extensions.Logging, update nuspec
  5. release NLog.Extensions.Logging (2.0?)

I could use some help on 1.

@304NotModified
Copy link
Member

closing this is favor of #25

@304NotModified
Copy link
Member

this has been released!

https://www.nuget.org/packages/NLog.Extensions.Logging/1.0.0-rtm-beta1

ASP.NET Core users should also install NLog.Web.AspNetCore: https://www.nuget.org/packages/NLog.web.aspnetcore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants