Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bubble_sort c++ implementation was (accidentally) replaced with C version #316

Closed
coderobe opened this issue Oct 6, 2018 · 6 comments
Closed

bubble_sort c++ implementation was (accidentally) replaced with C version #316

coderobe opened this issue Oct 6, 2018 · 6 comments
Labels
bug Something isn't working difficulty/low hacktoberfest HACKTOBERFEST 2020

Comments

@coderobe
Copy link
Contributor

coderobe commented Oct 6, 2018

6b2ca30#diff-3d53538d5b15b0bc3e6e499c6b48d150 seems to have moved the wrong file (see commit diff)
@sangamcse
Copy link
Member

GitMate.io thinks possibly related issues are #258 ([Algo] Merge Sort [C++]), #299 ([Algo] Counting Sort [C++]), #250 ([Algo] Quick Sort [C++]), #41 ([DataStructure] Stack [C++]), and #186 (euclidean_gcd in c++).

@sangamcse sangamcse added the bug Something isn't working label Oct 6, 2018
@zeddmaxx
Copy link

zeddmaxx commented Oct 6, 2018

Can I work on this?

@sangamcse
Copy link
Member

https://github.com/NITSkmOS/Algorithms/blob/master/bubble_sort/Cpp/bubble_sort.cpp looks fine to me 😄

@sangamcse
Copy link
Member

Fixed in 99cd8fb#diff-3d53538d5b15b0bc3e6e499c6b48d150
Related to #240

@coderobe
Copy link
Contributor Author

coderobe commented Nov 3, 2018

not really, compare it to the implementation at 6b2ca30#diff-3d53538d5b15b0bc3e6e499c6b48d150

@sangamcse
Copy link
Member

See the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working difficulty/low hacktoberfest HACKTOBERFEST 2020
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coderobe @zeddmaxx @sangamcse