Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the user's notifications in a popup #147

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Show the user's notifications in a popup #147

merged 3 commits into from
Dec 2, 2023

Conversation

ttoino
Copy link
Member

@ttoino ttoino commented Sep 26, 2023 •
edited
Loading

Closes #136

TODO: mark notifications as read and handle pagination

image

toni-santos
toni-santos approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@toni-santos toni-santos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, any additional testing/improvement will probably need to be done after a wider user test.

@ttoino
Copy link
Member Author

ttoino commented Dec 2, 2023

@LuisDuarte1 @thePeras @pedrosilva17 review pls 🥺

pedrosilva17
pedrosilva17 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@pedrosilva17 pedrosilva17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code, cleaner popup. Great job 🚀

@ttoino ttoino merged commit b0a2e04 into develop Dec 2, 2023
@ttoino ttoino deleted the feature/notifications-popup branch December 2, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrosilva17 pedrosilva17 pedrosilva17 approved these changes

@toni-santos toni-santos toni-santos approved these changes

@LuisDuarte1 LuisDuarte1 Awaiting requested review from LuisDuarte1

@thePeras thePeras Awaiting requested review from thePeras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show notifications in a dropdown
3 participants
@ttoino @toni-santos @pedrosilva17