From 06d65395d5ea65d4f4569a932bd9e08488c8a6dd Mon Sep 17 00:00:00 2001 From: Adrian Clay Date: Fri, 20 Oct 2023 10:54:48 +0100 Subject: [PATCH 1/2] Add timeout to Jenkins builds If a build takes longer than an hour, then somethings gone wrong and it's better to fail the build instead of pretending everything is fine. --- Jenkinsfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Jenkinsfile b/Jenkinsfile index 6959bdf4d..6530e8727 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -13,6 +13,7 @@ pipeline { options { timestamps() buildDiscarder(logRotator(numToKeepStr: "10")) + timeout(time: 1, unit: 'HOURS') } environment { From 1665bd059c14413f5d9aabb342ed561143e9a996 Mon Sep 17 00:00:00 2001 From: Adrian Clay Date: Fri, 20 Oct 2023 10:56:39 +0100 Subject: [PATCH 2/2] Add reminder to update mapping docs to PR checklist --- .github/pull_request_template.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7d2217257..28296c36d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -23,3 +23,6 @@ Please delete options that are not relevant. - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] I have updated the [Changelog](/CHANGELOG.md) with details of my change in the UNRELEASED section if this change will affect end users +- [ ] A corresponding change has been made to the [Mapping Documentation repository][mapping-docs] + +[mapping-docs]: https://github.com/NHSDigital/patient-switching-adaptors-mapping-documentation \ No newline at end of file