Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify units description in "bleaf" subroutine #968

Closed
adamhb opened this issue Jan 6, 2023 · 1 comment · Fixed by #1009
Closed

clarify units description in "bleaf" subroutine #968

adamhb opened this issue Jan 6, 2023 · 1 comment · Fixed by #1009
Labels
clean up Simple issues like typos, formatting, style guide alignment, etc.

Comments

@adamhb
Copy link
Contributor

adamhb commented Jan 6, 2023

The bleaf subroutine predicts plant leaf biomass in units of KgC, not biomass. We should probably update the units description for "bl" here to say "KgC" rather than "Kg" just to make it more explicit.
@rgknox
Copy link
Contributor

rgknox commented Jan 27, 2023

yeah, good point, maybe we can sneak this fix and the sapwood comment fix into another PR that is in queue

@glemieux glemieux added the clean up Simple issues like typos, formatting, style guide alignment, etc. label Apr 3, 2023
@glemieux glemieux mentioned this issue Apr 3, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean up Simple issues like typos, formatting, style guide alignment, etc.
Projects
FATES issue board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split associate statement to avoid NAG compiler line continuation issue glemieux/fates
3 participants
@rgknox @glemieux @adamhb