Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize cohort height during SP mode to use EDPftvarcon_inst%hgt_min #1064

Open
glemieux opened this issue Aug 18, 2023 · 0 comments
Open

Comments

@glemieux
Copy link
Contributor

glemieux commented Aug 18, 2023

During SP mode initialization, we currently initialize the cohort heights with a generic 0.5 overriding the local hite variable, which is set to EDPftvarcon_inst%hgt_min for non-SP mode runs:

fates/main/EDInitMod.F90

Lines 926 to 934 in 4f41112

hite = EDPftvarcon_inst%hgt_min(pft)
! h, dbh, leafc, n from SP values or from small initial size
if (hlm_use_sp .eq. itrue) then
! At this point, we do not know the bc_in values of tlai tsai and htop,
! so this is initializing to an arbitrary value for the very first timestep.
! Not sure if there's a way around this or not.
hite = 0.5_r8
call calculate_SP_properties(hite, 0.2_r8, 0.1_r8, &

Since we eventually update the cohort heights with the call to satellite_phenology which uses the incoming hlm_sp_htop value from the satellite phenology data (via the host land model), I don't think there is any reason to use the arbitrary 0.5 hardcoded value. We should try switching the init to using the hgt_min parameter.

See #1024 (comment) for further discussion and context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant