New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uninitialized bc_out%ema_npp in elm nitrogen fixation scheme #1039

Closed

rgknox opened this issue Jun 8, 2023 · 0 comments · Fixed by #1041

Contributor

rgknox commented Jun 8, 2023

NPP is potentially required for nitrogen fixation in ELM/CLM. While FATES C-only runs do not require nitrogen cycling, it doesn't mean that the soil N cycling is off (this is optional). At this line, E3SM queries what the exponential mean smoothed NPP is: https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/biogeochem/NitrogenDynamicsMod.F90#L209

Therefore, we have to make sure that this output boundary condition: https://github.com/NGEET/fates/blob/sci.1.65.7_api.25.4.0/main/FatesInterfaceMod.F90#L623 is not a nan when that code is run.

This was originally reported in this E3SM PR: E3SM-Project/E3SM#5599

rgknox mentioned this issue

Initialization of NPP moving average for N fixation in E3SM #1041

Merged

5 tasks

glemieux closed this as completed in #1041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment