Leaf orientation index range commented out

[adrifoster]

In EDSurfaceAlbedoMod a line capping the PFT parameter fates_leaf_xl (leaf orientation index) has been commented out. According to Gordon Bonan's textbook (page 238), "this equation is restricted to -0.4 < χ_l < 0.6"

Based off of many of my runs failing (for solar radiation balance check errors) when this parameter is outside those ranges (as well as within... but perhaps a separate issue), I think we should put this capping back.

[jkshuman]

Thanks for noting this @adrifoster and providing the reference to Gordon's book. Seems like your testing supports the change.

[adrifoster]

Suggestion from @JessicaNeedham: we should also perhaps put something to this effect in the parameter's long name in the parameter file. Just so folks know we are capping this parameter.

[rgknox]

@adrifoster I like @JessicaNeedham 's idea, and I'd also like to pair that with a graceful fail mechanism during the parameter checks in initialization if a user sets a value of xl outside this range. If we do this, maybe we don't apply capping in the radiation call, so the two methods don't diverge